Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

58 questions
3
votes
1 answer

How to initiate a pull-request for an old piece of code in a `git` medium?

I have a repository that I have developed over a period of time. It includes a series of files that I would like to get peer-reviewed via Pull-request. One pull-request for each file in this repo will be exactly what I need. In the past, I have…
Rotail
  • 1,025
  • 4
  • 19
  • 40
3
votes
2 answers

Github pull requests history

Is the history of the pull-requests preserved forever? I could not find anywhere for how long the pull-requests history is being saved.
Oron Bendavid
  • 1,485
  • 3
  • 18
  • 34
2
votes
0 answers

Improve git diffs when renaming and changing files

I'm converting quite a lot of code from JavaScript to TypeScript, which means: rename files from .js to .ts add type annotations etc Of course in many cases, such a refactoring can be substantial, and you might rewrite code completely to take…
JHH
  • 8,567
  • 8
  • 47
  • 91
2
votes
2 answers

Exclude files/directories from code review requirement

Our github repo includes a directory containing language translation files. These are generated automatically from a database. Ideally we should find a way to deploy these through some other mechanism than updating them in our github repository, but…
Barmar
  • 741,623
  • 53
  • 500
  • 612
2
votes
1 answer

Github Code Reviews: Automatically Reset and Rerequest Approvals after Changes

We have have programmers on our team that make changes after the Code Reviewers approved. Is there a way in Github, everytime a new file/edit is committed, Github would Automatically reset and ask Code Reviewers to reapprove? Currently programmers…
mattsmith5
  • 540
  • 4
  • 29
  • 67
2
votes
1 answer

How can I make a github PR requesting review of entire files?

There is this issue which is related, to allow commenting on parts of code OUTSIDE the change set. I'm just wondering if anyone has clever work arounds or a process to achieve something similar, maybe simpler. So I have a different sets of files…
Marvin
  • 2,537
  • 24
  • 35
2
votes
1 answer

Unable to figure operation of my github status check operation

This is my protected branch (master) configuration: And this is what I tried: $ git push Enumerating objects: 5, done. Counting objects: 100% (5/5), done. Delta compression using up to 4 threads Compressing objects: 100% (2/2), done. Writing…
AdityaGovardhan
  • 83
  • 1
  • 8
2
votes
0 answers

Github code review shows blank lines after, how to remove them?

Here is my work flow: git pull origin master git checkout -b test Make some changes git add . git commit -m"Add changes" git push origin test Then in code review, I saw some empty lines, so instead of change formatting line by line, I reset that…
ForeverYang
  • 81
  • 1
  • 7
2
votes
2 answers

GitHub Api check number of approvals on protected branch

I'm writing a server that should connect to GitHub and merge pull requests, but only if the required number of approvals is met. For my purpose it's not good enough to automatically merge the branch, I need to be able to track and record the number…
Forrest Keppler
  • 577
  • 3
  • 7
  • 20
1
vote
1 answer

BitBucket: Allow reviews post merge (a la GitHub)

In Bitbucket, on any Pull Request, reviews are disabled after the PR is merged. I'd like to continue to allow reviews after a PR is merged. Is this possible? NOTE: I am not asking about requiring review approval pre-merge, though I may or may not…
Peter H. Boling
  • 512
  • 5
  • 14
1
vote
1 answer

When to request a Code Review in Git Flow?

At my company we recently started using gitflow for managing our branches, my doubt is: at what point should code reviews be done? Simple gitflow: Let's say we have these opened pull request: feature/new-page -> develop develop -> release release…
Arthur
  • 99
  • 7
1
vote
0 answers

Documentation pull request review

I am used to document code reviews using a software called collaborator (https://smartbear.com/product/collaborator/overview/) Is there there any way we can create similar reports from GitHub pull request?
cricardol
  • 4,212
  • 3
  • 20
  • 28
1
vote
0 answers

How can I disallow code merge if checks and Teamcity build failed?

I am trying to do code reviews with GitHub and Teamcity. I want to place a Git Merge protection gatecheck, since last time, people placed compilation errors in our team Develop Git Branch. We know how to conduct Teamcity builds linking to…
mattsmith5
  • 540
  • 4
  • 29
  • 67
1
vote
0 answers

Duplicate Edge in Prim's Minimum Spanning tree

I've created a generic data structures and algorithm library written in C. I've tried to implement Minimum Spanning tree using the Prim's Algorithm When I run the code for a bi directional graph, I see that the reverse edge also gets added as part…
Mohammed Meraj
  • 116
  • 6
1
vote
2 answers

How to structure related pull requests

I'm working on a large section of a web app and have a several jira tickets assigned to me to complete it step by step: e.g. Task 1: create the main page of the section displaying a list of items Task 2: create a page with detailed item…
Dmitry Oleinik
  • 700
  • 1
  • 7
  • 20
1
2
3 4