Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

58 questions
0
votes
1 answer

Git how to rebase onto empty branch for code reviews

I'm following this recipe: https://thib.me/recipe-code-reviews-for-existing-code-with-github. In the interactive rebase step, I'm adding a pick line for the empty commit created in review-1-target repository as the first line in the rebase…
Peteris
  • 3,548
  • 4
  • 28
  • 44
0
votes
1 answer

How to find all users who wrote code in particular file in Git?

How to get the list of all users who contributed for this one file ?
Mayank_MP5
  • 153
  • 1
  • 8
0
votes
1 answer

Provide seamless access to reviewable.io reviews from github

We have a github repo with a reviewable.io webhook configured. What we are hoping for is that when any new developers are added as a contributor to the repo, they are automatically provided with seamless access to code reviews for this repo in…
opike
  • 7,053
  • 14
  • 68
  • 95
0
votes
1 answer

What is the purpose of non-collaborator reviews in GitHub?

GitHub documentation states: After a pull request is opened, anyone with read access can review and comment on the changes it proposes. In public GitHub repositories, what is the point of allowing people other than the repository owner or…
Miroslav Policki
  • 91
  • 1
  • 10
0
votes
1 answer

Any one used Sonarqube to review loadrunner scripts?

I would like to use Sonarqube to review LoadRunner/Jmeter scripts to check the code quality, are followed standards and best practice during test design. any one used Sonarqube to do that before?
AmarjeetM
  • 1
  • 1
  • 3
0
votes
3 answers

How to understand code like this in c++ [request->headers().Method()->value().getStringView())]

I am suppose to reduce it down to [request->headers().getMethodValue())]. I am fairly new to C++. Can someone please tell me how to understand this type of code? There are multiple . operator and -> operator. I loose track of the classes and…
Yashwant Yadav
  • 3
  • 1
0
votes
0 answers

GitHub I cannot add a reviewer to a pull request

I am the owner of a public GitHub repository but I cannot add anyone to review my pull request. It only shows "Nothing to show". I tried what was suggested on another similar question = to add a collaborator to the repository. But I cannot add…
PBA
  • 1
  • 1
0
votes
1 answer

How to do code reviews to Android applications in github?

As a team member, we work on creating an Android app with Github. We use PR's and code reviews. We also use Android Studio for development, It's hard to do code reviews to the layouts without actually seeing them. I was wondering if there is some…
vesii
  • 2,760
  • 4
  • 25
  • 71
0
votes
1 answer

Should I ignore automated code review errors for GUI class?

Should I ignore automated code review errors for GUI class? This class was generated by Windowbuilder. Should I make it differently so it has A grade in automated code reviews, and how should I do it, or should I ignored them because this types of…
Zoran Jankov
  • 236
  • 2
  • 5
  • 18
0
votes
2 answers

echo language construct is discouraged. (PHP)

why codacy(code review tool) showing "echo language construct is discouraged." how to solve this issue. 1:
Arun Maurya
  • 91
  • 1
  • 10
0
votes
0 answers

Isn't git-flow a bit ambiguous when it comes to raising MR for code reviews?

I am new to using git-flow and have got some queries. Let's say I have master & dev branches created upon git flow init and feature/master-api branch made from dev branch. Once I complete the feature I do git flow feature finish master-api. The…
Praveen Kamath
  • 959
  • 2
  • 10
  • 18
0
votes
1 answer

Implementing check in policy in swift 4

Suppose I have a class like this: class person{ } I need to implement a policy to check my code and warn me using camel case for my class name (use Person instead of person) How can I do it in Swift?
Ali Fallah
  • 753
  • 1
  • 7
  • 17
0
votes
1 answer

Code Collaborator file subscription for whole git repo

I'm trying to figure out what the right file pattern is to subscribe to any Code Collaborator reviews on a specific git repository. So let's say I'm using the following git repo: ssh://username@host:port/path/to/repo/example.git What is the file…
mac
  • 2,672
  • 4
  • 31
  • 43
1 2 3
4