Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

58 questions
1
vote
1 answer

How to use Phabricator only as a code review tool？

Our team currently uses gitlab as a code repository. Now we want to integrate a code review tool, but we hope that the code is still submitted directly to gitlab and the Phabricator just use for code review. What can i do? Are there any related…
Baiye
  • 11
  • 1
1
vote
1 answer

Don't require accepts for commits to develop branch with certain name pattern

In our GitHub repository we've recently enabled Require pull request reviews before merging rule for develop branch. Also, we have a little bash script that creates a new version that does the following: update version in pom.xml git commit create…
htshame
  • 6,599
  • 5
  • 36
  • 56
1
vote
2 answers

How to set up a code review workflow using gitlab,jenkins,git?

So my question is that i want to set up a code review flow , the tools i have are : git,gitlab,jenkins.. my idea is like to have a kind of forms or checklists that a member of the team need to fill whenever other member want to merge some new code ,…
Nawfal Nawfal
  • 29
  • 3
1
vote
1 answer

How to resolve a pullrequest review?

I created a pullrequest and reviewer reviewed it, posted comments and requested changes, I updated the pr with changes and resolved all the comment, but still at the bottom of the page, it shows someone requested changes and a red cross. Is there…
fluter
  • 13,238
  • 8
  • 62
  • 100
1
vote
1 answer

Pull request review from user without access to repo

I've been getting frequent emails saying something like... Hello, please review and approve this PR (link) ...only to be served a 404 from octobiwan. Inevitably I'll reply... I don't seem to have access to this repo, can you make sure you've…
Peter Vandivier
  • 606
  • 1
  • 9
  • 31
1
vote
1 answer

How do I get my code reviewed if I am owner of Github repository?

I have created a repository(of which I am the owner). My repository has about 5 contributors. We are able to review the code submitted by the contributors when they submit their pull request. What I need to know is there a way other than me opening…
ashish2199
  • 393
  • 3
  • 13
1
vote
2 answers

Append gerrit patch-set if commits were done locally

The issue I'm having is this: I have a git repository I was committing to locally via Pycharm's git plugin (not sure if that part of it is relevant). I pushed those changes to a gitlab repository. Now, I have to do codereview. Someone sends me a git…
frei
  • 495
  • 3
  • 19
1
vote
1 answer

Comment, Approve, Request Changes in Gihtub Pull Requests

Last week Gihtub introduced the Reviews functionality for Pull Requests. It was announced in the Github Blog. It seems to be very useful, except I am unable to find the options for requesting changes, commenting or approving changes in a Pull…
jvrsgsty
  • 588
  • 4
  • 18
1
vote
0 answers

Posting Github CodeReview Comments to Private Slack Messages

I want to connect GitHub and Slack in a very specific way. When a comment to a Github CodeReview is written, the user who has committed the code should get the comment as private message. Now I can do is to integrade slack and github with normal…
Boas Enkler
  • 12,264
  • 16
  • 69
  • 143
0
votes
0 answers

Providers/tools to support turn based code reviews

jetbrains space introduced a concept that they call "turn based code reviews": https://blog.jetbrains.com/space/2020/04/30/introducing-turn-based-code-reviews-in-space/ I really like it and it makes it much more efficient when you have to keep track…
Chris
  • 13,100
  • 23
  • 79
  • 162
0
votes
0 answers

How do you manage non-automatable compliance and tasks in code reviews?

We all appreciate the utility of automated checks during code reviews, such as linting, type checking, or security scans. However, there are certain compliance requirements or tasks that can't easily be automated. Some examples I can think of…
michaelecolley
  • 11
  • 2
0
votes
1 answer

How to configure PullApprove to send requests to a subset of a team that can submit approvals?

I'm using PullApprove v3 for GitHub PRs. I have a larger team general-team and a smaller team specific-team. specific-team is a subset of general-team. I want to allow PR approvals from anyone on general-team but only send requests to specific-team…
savagedata
  • 713
  • 1
  • 5
  • 10
0
votes
0 answers

How to review, test and validate mobile app sourse code online without exposing it to be stolen

I have a native android and IOS app developed for me by a conmpany and I want to recieve the source code from them. I want some third party external developers to help me in recieving the sourse code, reviewing and testing it to make sure that it is…
Mustafa M. Yahdeeh
  • 1
0
votes
1 answer

Does commiting to one file revoke all approvals provided to github pull request or not?

I have a pull request that makes changes to multiple files and codeowners of those files are different. Example: File_1 has codeowners X,Y,Z File_2 has codeowners A,B Initially X,Y and Z approved the PR but A and B suggested a change. So, if I…
akash deep
  • 135
  • 10
0
votes
1 answer

What is Crucible's "Add Latest" equivalent in GitHub?

I'm use to using Crucible on code reviews, but we started using Github pull-request. I've created a pull-request and now completed the changes suggested by one of the code reviewers. What I did was I committed the changes on the same branch but when…
Reydan Gatchalian
  • 171
  • 1
  • 10
1 2
3
4