Using selector to change TextView text color

Question

I'm trying to use a TextView to define the style of a TabWidget on a tabhost.

I just created a selector for bgcolor and works fine, but i want to make a selector for textColor but the text color don't change:

This is my tab_text_selector.xml:

<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android" >
     <item android:state_selected="true" android:color="@android:color/white" />
    <item android:state_focused="true" android:color="@android:color/white" />
    <item android:state_pressed="true" android:color="@android:color/white" />

</selector>

And this is the code when i'm trying to use on a textView:

TextView txtTab=new TextView(this);
        txtTab.setTextColor(R.drawable.tab_text_selector);
        txtTab.setBackgroundResource(R.drawable.tab_bg_selector);
        txtTab.setGravity(Gravity.CENTER);
        txtTab.setText("Agregar Idea");

I know the text color must be white in any case but it doesn't.

score 107 · Answer 1 · edited Oct 19 '17 at 05:51

107

1) Use tab_text_selector.xml as below and put it into res/color folder:

<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:state_selected="true" android:color="@android:color/white" />
    <item android:state_focused="true" android:color="@android:color/white" />
    <item android:state_pressed="true" android:color="@android:color/white" />
    <item android:color="#504f4f" /> <!-- default case -->
</selector>

And set it to your textview as below..

TextView tv = (TextView) findViewById(R.id.TextView1) ;
tv.setTextColor(context.getResources().getColor(R.color.tab_text_selector));

2) The Second option is If you are using textview in xml rather than using programatically then use tab_text_selector.xml as below :

<TextView
    android:id="@+id/textView1"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:gravity="center_horizontal"
    android:text="TextView"
    android:textColor="@‌drawable/tab_text_sel‌ector" />

edited Oct 19 '17 at 05:51

Komal12

3,340
4
16
25

answered Mar 19 '13 at 11:18

Sagar Shah

4,272
2
25
36

15

android:textColor="@drawable/tab_text_selector" to be exact – BAZTED May 13 '13 at 14:11
6

getColor will not work - you need to use getColorStateList() as mentioned in the answer by @ffeandro. Verified on 4.4.2 – Ben Clayton Jul 02 '14 at 17:08
8

@BAZTED did you even try `android:textColor="@drawable/tab_text_selector"` to change text color? By actually doing some code you would realize that `android:textColor="@color/tab_text_selector"` is actually the correct answer. I have no clue how anyone would upvote your comment when its misleading. – Andy Aug 13 '17 at 22:35
1

@Andy It depends where you put the `tab_text_selector.xml` file. In my experience these go in the `res/drawable` folder, but this answer says to put it in `res/color` which apparently works, but is a bit unusual. – k2col Jul 19 '18 at 17:15

score 62 · Accepted Answer · edited Nov 28 '18 at 10:12

62

You have to use getColorStateList(). And for xml, see here.

I was also struggling with this problem. If you want to have use a state list, you need to declare it in the color resources folder, instead of the drawable folder, and use the setTextColor(getResources().getColorStateList(R.color.tab_text_selector)) method.

edited Nov 28 '18 at 10:12

Dara

21
1
3

answered Jun 30 '13 at 01:34

ffleandro

4,039
4
33
48

1

I went ahead and made an edit to include the xml version. This answer was the most helpful out of all the other answers on changing the textcolor of a `TextView` based on the selector state. Literally all of them say `android:color` in the drawable selector. I wonder if any of them actually tried it out before answering thinking it was right. – Andy Aug 13 '17 at 22:29

score 30 · Answer 3 · edited Jun 20 '13 at 20:00

30

Use this way:

tab_text_selector.xml:

<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android" >
    <item android:state_pressed="true" android:color="#FF111111"/>  
    <item android:state_focused="true" android:color="#FF222222"/>    
    <item android:state_selected="true" android:color="#FF333333"/> 
</selector>

TextView:

TextView txtTab = new TextView(this);

XmlResourceParser xrp = getResources().getXml(R.drawable.tab_text_selector);  
try {  
    ColorStateList csl = ColorStateList.createFromXml(getResources(), xrp);  
    txtTab.setTextColor(csl);  
} catch (Exception e) {  } 

txtTab.setBackgroundResource(R.drawable.tab_bg_selector);
txtTab.setGravity(Gravity.CENTER);
txtTab.setText("Agregar Idea");

But it's better to put color in /res/color/yourcolor.xml

edited Jun 20 '13 at 20:00

spaaarky21

6,524
7
52
65

answered Apr 02 '12 at 19:06

ρяσѕρєя K

132,198
53
198
213

6

Is there a reason you are setting the TextView's `textColor` programmatically? Why not just add `android:textColor="@drawable/tab_text_selector"` to the layout? – spaaarky21 Jun 20 '13 at 20:02
2

Android Studio (and I assume Eclipse) will complain that getXml() is expecting an XML resource and throw a red underline error, but you can still compile and run your app just fine. If this is bugging you, move the selector XML file from R.drawable or R.color wherever you have it to R.xml and your IDE should stop complaining. – micnguyen Nov 26 '14 at 03:03

score 10 · Answer 4 · edited Mar 22 '17 at 08:07

Just make Selector for textcolor

<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:state_pressed="true" android:color="@color/drawer_color" />
<item android:state_focused="false" android:color="@android:color/white" />
<item android:state_selected="true" android:color="@color/drawer_color" />

Then set textColor property of Textview an set clickable=true

<TextView
    android:clickable="true"
    android:textColor="@drawable/text_selector"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="@string/registration"
    android:layout_alignParentRight="true"
    android:layout_alignParentEnd="true" />

You should add the XML to `res/color` and use it with `@color/something` rather than `@drawable/something` — Albert Vila Calvo, Aug 06 '20 at 12:29

score 7 · Answer 5 · answered Jul 09 '15 at 07:38

@ffleandro,@ρяσѕρєя K answers best variant, I think using ColorStateList best choice to older and latest versions of Android.

int[][] states = new int[][] {
    new int[] { android.R.attr.state_pressed}, // pressed
    new int[] { android.R.attr.state_focused}, // focused
    new int[] {}
};
int[] colors = new int[] {
    getResources().getColor(R.color.green_color), // green
    getResources().getColor(R.color.green_color), // green
    getResources().getColor(R.color.white)  // white
};
ColorStateList list = new ColorStateList(states, colors);
mTextView.setFocusable(true);
mTextView.setClickable(true);
mTextView.setTextColor(list);

score 2 · Answer 6 · edited Mar 22 '17 at 08:06

2

<item android:state_selected="true" android:color="@android:color/white" />
<item android:state_focused="true" android:color="@android:color/red" />
<item android:state_pressed="true" android:color="@android:color/blue" />

edited Mar 22 '17 at 08:06

Shabbir Dhangot

8,954
10
58
80

answered Apr 02 '12 at 19:01

Samir Mangroliya

39,918
16
117
134

score 1 · Answer 7 · answered Mar 08 '13 at 12:15

1

Here is reference on android developers http://developer.android.com/guide/topics/resources/color-list-resource.html

answered Mar 08 '13 at 12:15

snapix

344
2
8

While you explain nothing, the link is extremely helpful. – SMBiggs May 30 '16 at 19:58

score 1 · Answer 8 · answered Oct 12 '18 at 05:53

Create a selector (text_color_selector.xml) and put it into res/color folder:

<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:color="@color/colorPrimary" android:state_pressed="true" /> <!-- pressed -->
    <item android:color="@color/colorPrimary" android:state_focused="true" /> <!-- focused -->
    <item android:color="@color/light_gray_b" /> <!-- default -->
</selector>

add this into your Textview as:

        <TextView
            android:id="@+id/tvMenuName"
            style="@style/TextViewStyle"
            android:layout_marginLeft="@dimen/dimen_15"
            android:layout_marginStart="@dimen/dimen_15"
            android:textColor="@color/text_color_selector"
            android:textSize="@dimen/text_size_16"
            tools:text="Home" />

programmatically you can set Textview like this:

TextView tv = (TextView) findViewById(R.id.textView) ;
tv.setTextColor(context.getResources().getColor(R.color.text_color_selector));

Hope it helps.

score 0 · Answer 9 · edited Oct 12 '18 at 06:25

0

Easiest and effective solution:

create your Xml color selector into res/color/your_color.xml
Use ContextCompat util

Ex.: txtview.setTextColor( ContextCompat.getColorStateList(context, R.color.tab_tv_selector) );

edited Oct 12 '18 at 06:25

Rahul

3,293
2
31
43

answered May 22 '18 at 10:06

Sandipkumar Savani

159
1
6

score 0 · Answer 10 · answered Sep 24 '19 at 19:26

I had a different problem. I tried with everything which is suggested in this thread including the following

Moving the selector from the drawable folder to the color folder.
Setting the android:clickable="true"
Setting the android:duplicateParentState="true"

None of these seems to be working!

However, finally, I had to clean the project and got the selector working on my device. Thought putting this experience as an answer will help other developers.

Hence, the final working version had the following.

The selector file in the /res/color folder
And was added in the TextView with android:textColor="@color/text_selector"

score 0 · Answer 11 · edited Mar 22 '17 at 08:06

0

You have used the white color in all cases focus , selected and pressed..

Please use and test with different color.

Also must use a default case with certain color say black along with the all case.. when no state is used default will be applied.

edited Mar 22 '17 at 08:06

Shabbir Dhangot

8,954
10
58
80

answered Apr 02 '12 at 19:00

Arpit Garg

8,476
6
34
59

Using selector to change TextView text color

11 Answers11

1) Use tab_text_selector.xml as below and put it into res/color folder:

2) The Second option is If you are using textview in xml rather than using programatically then use tab_text_selector.xml as below :

Linked