Android: Set margins in a FrameLayout programmatically- not working

Question

here is the code-

FrameLayout.LayoutParams params = (FrameLayout.LayoutParams) searchPin.getLayoutParams();
params.setMargins(135, 176, 0, 0);
//params.leftMargin = 135; // also not worked 
//params.topMargin = 376;
searchPin.setLayoutParams(params);

Where ever, from xml its working-

android:layout_marginLeft="135dp"

what can be the reason? am i missing something!

-thnx

http://stackoverflow.com/questions/5401952/framelayout-margin-not-working — mathheadinclouds, Jan 09 '15 at 15:12

score 17 · Accepted Answer · edited Jul 11 '12 at 10:43

17

Try this:

params.gravity = Gravity.TOP;

edited Jul 11 '12 at 10:43

Druid

6,423
4
41
56

answered Jul 05 '12 at 15:59

jdo59

194
1
2

3

or even: params.gravity = Gravity.NO_GRAVITY; – Christopher Moore Jul 17 '12 at 19:07

score 12 · Answer 2 · answered Aug 05 '12 at 23:28

12

I had a FrameLayout child of a RelativeLayout so the framework was trying to cast FrameLayout params to RelativeLayout, I solved this way

FrameLayout mylayout = (FrameLayout) view.findViewById(R.id.mylayout);
ViewGroup.MarginLayoutParams params = (MarginLayoutParams) mylayout.getLayoutParams();
params.setMargins(1, 2, 3, 4);
mylayout.setLayoutParams(params);

answered Aug 05 '12 at 23:28

sherpya

4,890
2
34
50

1

if your FrameLayout is a child of RelativeLayout. the you've got set RelativeLayout.LayoutParams to FrameLayout – Roman Black Nov 21 '13 at 10:48
agree w/Roman Black: This is the solution that worked for me. You need to set the params with the type of the parent. – mtbomb Nov 20 '14 at 07:44
Maybe @sherpya didn't express himself clearly but he certainly made a point. `FrameLayout.LayoutParams` is not the same as `ViewGroup.LayoutParams` – Aleks Nine Oct 30 '15 at 12:41

hovanessyan · Answer 3 · 2013-03-29T16:19:11.237

4

I think what you're missing is that, when you set programmatically the parameters for an element, those parameters are provided actually to the parent View, so that it knows how to position the element. The parameters are not set back to the element itself. Consider the following code example. Also note, that the layout parameters are of the type of the parent.

LinearLayout linearLayout = new LinearLayout(this);

LinearLayout.LayoutParams layoutParams = new LinearLayout.LayoutParams(
     LinearLayout.LayoutParams.FILL_PARENT, 
     LinearLayout.LayoutParams.WRAP_CONTENT);

layoutParams.setMargins(6,6,6,6);

Button someButton=new Button(this);
someButton.setText("some text");

linearLayout.addView(someButton, layoutParams);

edited Mar 29 '13 at 16:19

answered Nov 12 '11 at 00:41

hovanessyan

30,580
6
55
83

then what should I do for child element? Instead of that, do i need to add padding for parent - to properly place the child! – Avisek Chakraborty Nov 12 '11 at 08:25
no, you don't have to set padding for child element, as padding to parent. The idea is more like, you supply both (child element + child element layout params) to the parent- as in the addView line. – hovanessyan Nov 12 '11 at 11:01
Not working either, using addView with two parameters, or setting the layout parameters to the view directly results in the same – htafoya Jun 19 '12 at 16:04

score 3 · Answer 4 · answered Jan 21 '14 at 13:42

You can try this

FrameLayout.LayoutParams srcLp = (FrameLayout.LayoutParams)searchPin.getLayoutParams();
FrameLayout.LayoutParams lp = new FrameLayout.LayoutParams(srcLp.width, srcLp.height, srcLp.gravity);

lp.setMargins(srcLp.leftMargin, srcLp.topMargin, srcLp.rightMargin, srcLp.bottomMargin);

searchPin.setLayoutParams(lp);

score 2 · Answer 5 · answered Nov 12 '11 at 10:06

2

simple solution-

searchPin = (ImageView) findViewById(R.id.waypts_search_pin);
searchPin.setPadding(135, 176, 0, 0);

answered Nov 12 '11 at 10:06

Avisek Chakraborty

8,229
10
48
76

10

Well this doesn't really help other people who are searching for an answer to your question, Padding doesn't move the background on the frame, just the contents. – htafoya Jun 19 '12 at 16:05

score -1 · Answer 6 · answered Jul 03 '12 at 15:32

-1

Just use LayoutParams instead of FrameLayout.LayoutParams

LayoutParams params = (LayoutParams) searchPin.getLayoutParams();
params.setMargins(135, 176, 0, 0);
searchPin.setLayoutParams(params);

this worked for me

answered Jul 03 '12 at 15:32

stef

525
6
14

1

LayoutParams doesn't have a setMargins method. You've just imported android.widget.FrameLayout.LayoutParams – roarster Jan 05 '14 at 18:05

Android: Set margins in a FrameLayout programmatically- not working

6 Answers6

Linked