107

I am trying to access the value of the input file from my ionic 2 application but still I'm facing the issue of property files does not exist on type 'EventTarget'. As it is properly working in js but not in typescript. The code is given below:

  document.getElementById("customimage").onchange= function(e?) {
            var files: any = e.target.files[0]; 
              EXIF.getData(e.target.files[0], function() {
                  alert(EXIF.getTag(this,"GPSLatitude"));
              });
          }

Please help me solve this issue as it is not building my ionic 2 application.

Chirag Chaudhari
  • 1,617
  • 3
  • 14
  • 20

13 Answers13

123

You can cast it as a HTMLInputElement:

document.getElementById("customimage").onchange = function(e: Event) {
    let file = (<HTMLInputElement>e.target).files[0];
    // rest of your code...
}

Update:

You can also use this:

let file = (e.target as HTMLInputElement).files[0];
Francesco Borzi
  • 56,083
  • 47
  • 179
  • 252
soroush gholamzadeh
  • 2,616
  • 1
  • 22
  • 30
77

The e.target property type depends on the element you are returning on getElementById(...). files is a property of input element: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement

In this case, the TypeScript compiler doesn't know you are returning an input element and we dont have an Event class specific for this. So, you can create one like the following code:

interface HTMLInputEvent extends Event {
    target: HTMLInputElement & EventTarget;
}

document.getElementById("customimage").onchange = function(e?: HTMLInputEvent) {
    let files: any = e.target.files[0]; 
    //...
}
Diullei
  • 11,420
  • 2
  • 27
  • 31
  • 4
    As someone suggested below you may just use: "e: any". I was wondering what are the pros for using the approach offered here? – Tomer Oct 27 '17 at 21:18
  • 13
    @Tomer, it's more likely because there is no pros of loosing the type of typescript. Each time you are using "any" you remove the types guards. – Flavien Volken Jan 08 '18 at 08:31
  • 1
    Exactly right. In a nutshell, if you use "any" here, you may as well not use TypeScript at all. That's a bit hyperbolic -- I've been known to use "any" when I'm not in the mood to define a type just for a single function's parameter -- but the logic is consistent; the only reason to use TypeScript at all is to allow the compiler to assist you by preventing you from making type-based mistakes. – Lucas Leblanc Aug 16 '18 at 19:04
  • I like the suggested approach but I'm not sure regarding the purpose of *& EventTarget* part. I understand that *target: HTMLInputElement* adds a property to the extended type *Event* that's called *target* and is of type *HTMLInputElement*. But what do we gain by saying "*oh, right, it can also be of another type too...*". What am I missing here? – Konrad Viltersten Feb 01 '20 at 14:17
61

This is more lines, but I think it's the clearest.

    const onChange = (event: Event) => {
      const target= event.target as HTMLInputElement;
      const file: File = (target.files as FileList)[0];
      /** do something with the file **/
    };

2022 update: Some people have rightly pointed out that the two casts on the second line are unnecessary, this is totally correct and I've revised my answer.

    const onChange = (event: React.ChangeEvent) => {
        const target= event.target as HTMLInputElement;
        const file = target.files[0];
        /** do something with the file **/
    };
Devin Clark
  • 1,078
  • 11
  • 9
  • What type would you suggest for the *reader.onloadend = ($event: ProgressEvent) => { ... }* when I try to access *$event.target*? The target is of a type that has a property called *result* but my TsLint complains about the property not being there (due to the type not properly set by me, of course). – Konrad Viltersten Jan 31 '20 at 22:06
  • I mean like in [this sample](https://developer.mozilla.org/en-US/docs/Web/API/FileReader/onload). What is the type of *e.target* and *e.target.result*? – Konrad Viltersten Jan 31 '20 at 22:09
  • You dont need to cast the files. When you cast the HTMLInputElement, it automatically inferes the target.files type. Plus, it's dangerous to go around casting everything. The lesser you cast, the better. – Javi Marzán May 07 '20 at 12:37
  • 2
    I surfed at least half of the internet to find this solution. It is quite difficult to explain to other developers why strong typing is necessary in computing. Thank you a lot @Devin Clark – Nicolas May 24 '20 at 20:37
13
const handleFileInput = (event: ChangeEvent) => {
        const target = event.target as HTMLInputElement;
        const file: File = (target.files as FileList)[0];
        /** do something with the file **/
    };

I would change Event to ChangeEvent, however the rest of Devin Clark's answer is great :)

darmou
  • 131
  • 2
  • 4
5
// use - ChangeEvent<HTMLInputElement>

document.getElementById("customimage").onchange= function(e?: ChangeEvent<HTMLInputElement>) {
            var files: any = e.target.files[0]; 
              EXIF.getData(e.target.files[0], function() {
                  alert(EXIF.getTag(this,"GPSLatitude"));
              });
          }
skinnynpale
  • 51
  • 1
  • 3
5
const onChange => (event: Event): void {
    const input = event.target as HTMLInputElement;

    if (!input.files?.length) {
        return;
    }

    const file = input.files[0];
    console.log(file);
}
nkitku
  • 4,779
  • 1
  • 31
  • 27
3

I have found that:

<input type="file"  accept="image/*" 
(change)="upload($event)">

and

<ion-input type="file"  accept="image/*" 
(change)="upload($event)"><ion-input>  or (ionChange)

does not handle the event in the same way. Therefore event.target consists of different parameters.

I therefore did not use the ion-input tag, but the normal angular <input> tag with the (change)="upload($event)" trigger.

It worked for me on Ionic 4.

סטנלי גרונן
  • 2,917
  • 23
  • 46
  • 68
3

Based on a few other answers and slight refactoring over time I now commonly cast the ChangeEvent in one line like so:

const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
  const files = e.target.files;
  if (!files || !files.length) {
    alert("Please select a file!");
  }
}
Alex Dunlop
  • 1,383
  • 15
  • 24
2

Better avoid Type Casting whenever possible. Use e.currentTarget instead of e.target

arudzevych
  • 66
  • 4
0

I just come to solved the same probleme, when I use :

e.target.files

It said that target doesnot have files property, so as you said in type script. You can also use :

e.target['files'][0]

It solved my probleme.

Ibrahim Kelly
  • 548
  • 1
  • 4
  • 9
0

my problem is solved, I am use <any>

if you use useRef, it's also work

0
function getImg(e: Event) {
  
    const target = e.target as HTMLInputElement;
    const files = target?.files;

    if (files) {
        let url = window.URL.createObjectURL(files[0]);
        return url;
    }

}
0

after many iterations, this is what worked for me:

async function upload(e: Event & { currentTarget: EventTarget & HTMLInputElement }) {
    if (!e.currentTarget || !e.currentTarget.files) return;
    const file = e.currentTarget.files[0];
    //...
}

i'm on typescript@^5.1.6, using svelte's on:change={upload} but unsure if that's relevant

KraXen72
  • 96
  • 1
  • 1
  • 7