Fragment created multiple times within RadioGroup

Question

I have an activity with a RadioGroup that has two RadioButtons. The RadioButtons behave like tabs and should create two different fragments, depending on which of the buttons has been clicked. The problem is that the fragments' onCreateView methods are called twice and I can't figure out why.

This is my Activity:

public class MyActivity {

private RadioGroup radioGroup;
private FrameLayout frame;
private RadioButton radio1;
private RadioButton radio2;

private RadioOneFragment radio1Fragment;
private RadioTwoFragment radio2Fragment;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.my_activity_layout);

    radio1 = (RadioButton) findViewById(R.id.radio1);
    radio2 = (RadioButton) findViewById(R.id.radio2);

    radioGroup = (RadioGroup) findViewById(R.id.radioGroup);
    radioGroup.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
        @Override
        public void onCheckedChanged(RadioGroup group, int checkedId) {
            switch (checkedId) {
                case R.id.radio1:
                    radio1Fragment = new RadioOneFragment();
                    getFragmentManager().beginTransaction()
                            .replace(R.id.radio_frg_container, radio1Fragment)
                            .commit();
                    break;
                case R.id.radio2:
                    radio2Fragment = new RadioTwoFragment();
                    getFragmentManager().beginTransaction()
                            .replace(R.id.radio_frg_container, radio2Fragment)
                            .commit();
                    break;
            }
        }
    });
    if (getIntent().getExtras() != null) {
        radioGroup.check(R.id.radio2);
    } else {
        radioGroup.check(R.id.radio1);
    }
}
}

Any help is greatly appreciated. Thanks.

Is this behavior caused because I'm checking the radiobuttons within my code? — user3165984, Sep 08 '15 at 08:03

score 1 · Answer 1 · edited May 23 '17 at 11:45

1

I've found the answer here: RadioGroup calls onCheckChanged() three times

Instead of using radioGroup.check(R.id.radio1) you should simply use radio1.setChecked(true).

edited May 23 '17 at 11:45

Community

1
1

answered Sep 12 '15 at 12:49

user3165984

121
2
10

score 0 · Answer 2 · answered Sep 06 '15 at 19:47

Try one Fragment object

private RadioOneFragment radio1Fragment;
private RadioTwoFragment radio2Fragment;

instace of

private RadioTwoFragment radioFragment;

and

switch (checkedId) {
                case R.id.radio1:
                    radioFragment = new RadioOneFragment();
                    getFragmentManager().beginTransaction()
                            .replace(R.id.radio_frg_container, radioFragment)
                            .commit();
                    break;
                case R.id.radio2:
                    radioFragment = new RadioTwoFragment();
                    getFragmentManager().beginTransaction()
                            .replace(R.id.radio_frg_container, radioFragment)
                            .commit();
                    break;
            }

Thanks, but unfortunately this did not solve the problem – user3165984 Sep 06 '15 at 20:11 — user3165984, Sep 06 '15 at 20:11

Fragment created multiple times within RadioGroup

2 Answers2