RadioGroup calls onCheckChanged() three times

Question

I've been struggling with an issue of programmatic checking of a RadioButton, which is situated in a RadioGroup. It seems that a single check() call raises three events - once for the first RadioButton and twice for the second, which is my target. At the same time clicking on the second RadioButton in the interface causes only one event to appear, which is correct.

So, is there a way to avoid multiple event raising ?

public class RadiogroupActivity extends Activity {
    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);

        RadioGroup r = (RadioGroup) findViewById(R.id.radioGroup1);
        RadioButton b = (RadioButton) findViewById(R.id.radio1);
        r.setOnCheckedChangeListener(onPromobuttonsClick);
        r.check(R.id.radio1);

    }

    private OnCheckedChangeListener onPromobuttonsClick = new OnCheckedChangeListener() {
        @Override
        public void onCheckedChanged(RadioGroup group, int checkedId) {
            Log.d("x", "x");
        }
    };
}

Sam · Accepted Answer · 2012-12-21T23:47:22.110

54

So, is there a way to avoid multiple event raising ?

Call b.setChecked(true); instead.

A quick look through the source code confirms that RadioGroup#check() really does call the OnCheckChangedListener three times...

When the current selection is unchecked,
When the new RadioButton is checked, and
When the RadioGroup saves which RadioButton is now checked.

Odd quirk.

edited Dec 21 '12 at 23:47

answered Apr 21 '12 at 23:45

Sam

86,580
20
181
179

Sir : Need your help .Take a look please http://stackoverflow.com/questions/22602559/how-do-implement-this-in-android – Mar 25 '14 at 05:28
1

Really saved my life... Superb @Sam – TechArcSri May 01 '14 at 12:31
Please elaborate answer more . I am not getting your answer. – Anand Savjani May 05 '16 at 06:28
Yes, really save my time Thanks @Sam – Parth Patel Sep 11 '20 at 14:01

score 4 · Answer 2 · answered May 05 '16 at 06:45

4

Simply post your r.setOnCheckedChangeListener(onPromobuttonsClick); line in onResume() method. It is works for me.

answered May 05 '16 at 06:45

Anand Savjani

2,484
3
26
39

score 1 · Answer 3 · answered Sep 13 '16 at 18:10

So this is an old one but I also got a similar behavior. A workaround that I found was to call the toggle() method of RadioButton instead of the check() method of RadioGroup.

So in this example, you woulod just need to swap

r.check(R.id.radio1);

with

b.toggle();

since b is already the view with id R.id.radio1.

score 1 · Answer 4 · answered Jan 13 '17 at 19:07

I had this problem when I wanted to log analytics for radio button presses, but the way the radio groups calls were being handled with .check() caused onCheckedChangeListener to get called multiple times (which sent too many events).

I handled it the following way to only get one event per click:

// create listeners so we don't duplicate the creation in for loop
View.OnClickListener onClickListener = new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        // whatever you want to do here
    }
};

// add on click listener to all radio buttons
int buttonCount = buttonGroup.getChildCount();
for (int i = 0; i < buttonCount; i++) {
    if (buttonGroup.getChildAt(i) instanceof RadioButton) {
        buttonGroup.getChildAt(i).setOnClickListener(onClickListener);
    }
}

score 0 · Answer 5 · answered Jan 05 '22 at 19:20

This is a old question but I didn't found a complete answer yet that cover my issue. But thanks to #Hellojeffy suggestion I figured a way to handle the situation when RadioButton trigger multipletimes when using setOnCheckedChangeListener(). The idea is to add a click on each view inside the RadioGroup and trigger a event on click, instead a event on check changes.

for (child in radioButtonGroup.children) {
            if (child is RadioButton) {
                when (child.id) {
                    R.id.rb1 -> child.setOnClickListener { onRb1Click(...) }
                    R.id.rb2 -> child.setOnClickListener { onRb1Click(...) }
                    R.id.rb3 -> child.setOnClickListener { onRb1Click(...) }
                        ...
                }
            }
        }

RadioGroup calls onCheckChanged() three times

5 Answers5

Linked

Related