15

I got the following warning:

Custom view com/example/view/adapter/SomeAdapter is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

in my class SomeAdapter which extends some BaseAdapter which extends ArrayAdapter

public class SomeAdapter extends BaseAdapter{}
public abstract class BaseAdapter extends ArrayAdapter<SomeModel>{}

The warning exists in the concrete adapter but not in the abstract BaseAdapter. Has anyone ever heard of this warning in that context?

AFAIK Android checks classes for they are extending views by checking the name of the super classes via ViewConstructorDetector:

 private static boolean isViewClass(ClassContext context, ClassNode node) {
    String superName = node.superName;
    while (superName != null) {
        if (superName.equals("android/view/View")                //$NON-NLS-1$
                || superName.equals("android/view/ViewGroup")    //$NON-NLS-1$
                || superName.startsWith("android/widget/")       //$NON-NLS-1$
                && !((superName.endsWith("Adapter")              //$NON-NLS-1$
                        || superName.endsWith("Controller")      //$NON-NLS-1$
                        || superName.endsWith("Service")         //$NON-NLS-1$
                        || superName.endsWith("Provider")        //$NON-NLS-1$
                        || superName.endsWith("Filter")))) {     //$NON-NLS-1$
            return true;
        }

        superName = context.getDriver().getSuperClass(superName);
    }

    return false;
}

As far as I can see my class names don't match the pattern above. Does anyone has any idea how to fix or suppress this warning?

getView() in BaseAdapter:

@Override
public final View getView(final int position, final View convertView, final ViewGroup parent) {
    View view = convertView;
    if (null == view) {
        view = createNewView(parent, position);
    } else {
        reuseOldView(view, position);
    }
    return view;
}
Carl Anderson
  • 3,446
  • 1
  • 25
  • 45
salcosand
  • 2,022
  • 4
  • 24
  • 27

4 Answers4

12

In your CustomView class add constructors:

public CustomView(Context context) {
    super(context);
}
public CustomView(Context context, AttributeSet attrs) {
    super(context, attrs);
}
Jarvis
  • 1,527
  • 12
  • 17
  • I don't have any CusonView. I just have my Adapters. And the ArrayAdapter does not provide such constructors. – salcosand Jun 12 '13 at 12:00
  • Could you post your getView() method from your adapters? Thanks – Jarvis Jun 12 '13 at 15:19
  • I'm not sure what is this good for, but here you go. The getView() is implemented in the BaseAdapter but not in the SomeAdapter, where the warning is. – salcosand Jun 12 '13 at 16:08
4

Please try below in Kotlin:-

 class CustomView: View {
    constructor(context: Context) : this(context, null)
    constructor(context: Context, attrs: AttributeSet?) : this(context, attrs, 0)
    constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(context, attrs, defStyleAttr) {
    }
}
Shalu T D
  • 3,921
  • 2
  • 26
  • 37
3

Some layout tools (such as the Android layout editor for Eclipse) needs to find a constructor with one of the following signatures: * View(Context context) * View(Context context, AttributeSet attrs) * View(Context context, AttributeSet attrs, int defStyle)

If you are not using such things, and just want to get rid of this warning for all your projects just go to:

Window -> Preferences -> Android -> Lint Error Checking.

Find ViewConstructor from the list and set the severity to 'ignore'.

Caner
  • 57,267
  • 35
  • 174
  • 180
  • Does this influence the layout editor? What I don't understand is why does Lint think my adapter is a view. – salcosand Jul 12 '13 at 10:55
1

You are using a custom View class, you'll need to add the missing constructors to your class.

In Java, you can use Jarvis' answer:

class YourCustomView {
    public YourCustomView(Context context) {
        super(context);
    }
    public YourCustomView(Context context, AttributeSet attrs) {
        super(context, attrs);
    }
}

It's more more compact in Kotlin:

class YourCustomView @JvmOverloads constructor(
        context: Context, attrs: AttributeSet? = null, defStyleAttr: Int = 0
) : View(context, attrs, defStyleAttr)
ericn
  • 12,476
  • 16
  • 84
  • 127