How to write a node.js function that waits for an event to fire before 'returning'?

Question

I have a node application that is not a web application - it completes a series of asynchronous tasks before returning 1. Immediately before returning, the results of the program are printed to the console.

How do I make sure all the asynchronous work is completed before returning? I was able to achieve something similar to this in a web application by making sure all tasks we completed before calling res.end(), but I haven't any equivalent for a final 'event' to call before letting a script return.

See below for my (broken) function currently, attempting to wait until callStack is empty. I just discovered that this is a kind of nonsensical approach because node waits for processHub to complete before entering any of the asynchronous functions called in processObjWithRef.

function processHub(hubFileContents){
    var callStack = [];
    var myNewObj = {};
    processObjWithRef(samplePayload, myNewObj, callStack);
    while(callStack.length>0){
        //do nothing
    }
    return 1
}

Note: I have tried many times previously to achieve this kind of behavior with libraries like async (see my related question at How can I make this call to request in nodejs synchronous?) so please take the answer and comments there into account before suggesting any answers based on 'just use asynch'.

"How do I make sure all the asynchronous work is completed before returning?" Is a nonsensical question - control is never returned to the shell until all asynchronous tasks have completed, so leaving console output until after the very last asynchronous function has completed fixed my problem. Thanks all for submitting answers. — Trindaz, Mar 30 '12 at 03:48

score 6 · Answer 1 · edited May 23 '17 at 11:46

You cannot wait for an asynchronous event before returning--that's the definition of asynchronous! Trying to force Node into this programming style will only cause you pain. A naive example would be to check periodically to see if callstack is empty.

var callstack = [...];

function processHub(contents) {
  doSomethingAsync(..., callstack);
}

// check every second to see if callstack is empty
var interval = setInterval(function() {
  if (callstack.length == 0) {
    clearInterval(interval);
    doSomething()
  }
}, 1000);

Instead, the usual way to do async stuff in Node is to implement a callback to your function.

function processHub(hubFileContents, callback){
  var callStack = [];
  var myNewObj = {};
  processObjWithRef(samplePayload, myNewObj, callStack, function() {
    if (callStack.length == 0) {
      callback(some_results);
    }
  });
}

If you really want to return something, check out promises; they are guaranteed to emit an event either immediately or at some point in the future when they are resolved.

function processHub(hubFileContents){
  var callStack = [];
  var myNewObj = {};
  var promise = new Promise();

  // assuming processObjWithRef takes a callback
  processObjWithRef(samplePayload, myNewObj, callStack, function() {
    if (callStack.length == 0) {
      promise.resolve(some_results);
    }
  });

  return promise;
}

processHubPromise = processHub(...);
processHubPromise.then(function(result) {
  // do something with 'result' when complete
});

abbr · Answer 2 · 2017-12-09T21:14:30.377

4

deasync is desinged to address your problem exactly. Just replace

while(callStack.length>0){
    //do nothing
}

with

require('deasync').loopWhile(function(){return callStack.length>0;});

edited Dec 09 '17 at 21:14

answered Dec 24 '14 at 19:55

abbr

5,361
6
30
44

score 4 · Accepted Answer · edited Mar 12 '19 at 19:24

The problem is with your design of the function. You want to return a synchronous result from a list of tasks that are executed asynchronously.

You should implement your function with an extra parameter that will be the callback where you would put the result (in this case, 1) for some consumer to do something with it.

Also you need to have a callback parameter in your inner function, otherwise you won't know when it ends. If this last thing is not possible, then you should do some kind of polling (using setInterval perhaps) to test when the callStack array is populated.

Remember, in Javascript you should never ever do a busy wait. That will lock your program entirely as it runs on a single process.

Downvoted because this doesn't answer the question. There may be cases where you writing, say, a small command-line program or an AWS Lambda where you don't care if the main thread is blocked. — Charles Spencer, Mar 19 '18 at 20:49

score 1 · Answer 4 · answered Dec 24 '14 at 23:33

Node.js runs on A SINGLE threaded event loop and leverages asynchronous calls for doing various things, like I/O operations.

if you need to wait for a number of asynchronous operations to finish before executing additional code you can try using Async -

Node.js Async Tutorial

score 1 · Answer 5 · answered Mar 30 '12 at 02:13

The problem is that node.js is single-threaded, which means that if one function runs, nothing else runs (event-loop) until that function has returned. So you can not block a function to make it return after async stuff is done.

You could, for example, set up a counter variable that counts started async tasks and decrement that counter using a callback function (that gets called after the task has finished) from your async code.

score 0 · Answer 6 · answered Mar 30 '12 at 04:51

You'll need to start designing and thinking asynchronously, which can take a little while to get used to at first. This is a simple example of how you would tackle something like "returning" after a function call.

function doStuff(param, cb) {
    //do something
    var newData = param;
    //"return"
    cb(newData);
}

doStuff({some:data}, function(myNewData) {
    //you're done with doStuff in here
});

There's also a lot of helpful utility functions in the async library available on npm.

How to write a node.js function that waits for an event to fire before 'returning'?

6 Answers6

Linked