Catching MessageBox result

Question

I'm trying to get the user to confirm if they want to delete a product using a MessageBox and catching its result. This is my code:

// Confirm if the user really wants to delete the product
DialogResult result = MessageBox.Show("Do you really want to delete the product \"" + productName + "\"?", "Confirm product deletion", MessageBoxButtons.YesNo, MessageBoxIcon.Warning);
if (result == DialogResult.OK)
{
    MessageBox.Show("deleted");
}

When I run the code and try to delete a product, deleted never shows. On the MSDN page it says to use MessageBoxResult rather than DialogResult but Visual Studio doesn't recognise MessageBoxResult, and I use DialogResult elsewhere in my code for an open file dialog. Obviously, that's not the proper way to check it.

Agustin Meriles · Accepted Answer · 2016-12-19T11:51:48.477

6

You must ask for DialogResult.Yes

// Confirm if the user really wants to delete the product
DialogResult result = MessageBox.Show("Do you really want to delete the product \"" +     productName + "\"?", "Confirm product deletion", MessageBoxButtons.YesNo,  MessageBoxIcon.Warning);
if (result == DialogResult.Yes)
{
    MessageBox.Show("deleted");
}

edited Dec 19 '16 at 11:51

answered Mar 27 '12 at 21:25

Agustin Meriles

4,866
3
29
44

score 1 · Answer 2 · answered Mar 27 '12 at 21:26

1

You have the message box type set to yes/no, yet you are trying to catch an OK result. Catch the yes and you will be sorted.

answered Mar 27 '12 at 21:26

TomP89

1,420
3
11
29

score 0 · Answer 3 · answered Mar 27 '12 at 21:27

0

You are using the YesNo buttons, so the DialogResult.OK has nothing to do with it. You should do

if (result == DialogResult.Yes)

for your condition.

answered Mar 27 '12 at 21:27

SimpleVar

14,044
4
38
60

score 0 · Answer 4 · answered Mar 27 '12 at 21:29

Just ask for the right DialogResult.

if (result == DialogResult.Yes)

Bear in mind, that a dialog can have different kind of results, and that you are also able to write your own results. Therefore: Have always a look on the result you are expecting and on the result you are checking.

Greetings,

Catching MessageBox result

4 Answers4