3

I am having trouble installing DWSScript component. I am using Delphi XE2 and when I try to compile the dwsLibRuntime.dpk I get an error ( Array type required ). I am using the latest DWScript source pulled from the project's svn repo.

What am I doing wrong?

 toStr:=TStringListCracker(sl).FList[i].FString; //produces error
 System.MonitorExit(sl);
David Heffernan
  • 601,492
  • 42
  • 1,072
  • 1,490
opc0de
  • 11,557
  • 14
  • 94
  • 187
  • @DavidHeffernan i mentioned that i am using delphi xe 2 ;) what can i do in this case ? – opc0de Mar 27 '12 at 08:06
  • yep i have the last version ... – opc0de Mar 27 '12 at 08:08
  • 1
    Are you sure you are compiling with XE2? I can see that the implementation of `TStringList` has changed (certainly between 2010 and XE2) in a way that would explain that error. – David Heffernan Mar 27 '12 at 08:21
  • 1
    As a complete aside, does anyone know why this code feels the need to poke around with the private implementation details of `TStringList`? – David Heffernan Mar 27 '12 at 08:26
  • @DavidHeffernan yes i am pretty shure i know what compiler i am using :) – opc0de Mar 27 '12 at 08:26
  • Have a read of the implementation of `TStringList` in your XE2 RTL source code and you'll see why I am puzzled. – David Heffernan Mar 27 '12 at 08:28
  • 1
    @David: it's a speed optimization, it removes a complex call, a range check, an UStrAsg and accompanying bus lock from a critical section, along with an implicit exception frame in UnifyAssignString (used to guard the return value of the Get) and reduce register pressure in UnifyAssignString. Speedup is a few percent points in single-threaded situations up to 20-30% in some heavily multi-threaded scenarios. Just look at the code in the CPU view between the cracker-hack and the "toStr:=sl[i]" variant. – Eric Grange Mar 27 '12 at 09:11
  • @Eric Thanks. Any idea why opc0de is getting this error? Seems pretty inexplicable to me. – David Heffernan Mar 27 '12 at 09:22
  • @David: his source seems out of date, the Monitor isn't used there and was replaced in february 2011. – Eric Grange Mar 27 '12 at 09:55

2 Answers2

10

You're not using the latest version, the monitor isn't used anymore (due to contention bugs in the RTL implementation), the second line should read as "sl.FLock.Leave;". You're likely on a pre-Delphi XE2 version, as the Monitor was dropped in february 2011.

http://code.google.com/p/dwscript/source/browse/trunk/Source/dwsUtils.pas#475

Make sure you're on the head/trunk, or Delphi isn't pointed to a different directory than the one updated by your SVN client.

Eric Grange
  • 5,931
  • 1
  • 39
  • 61
  • is there any link to an Installation guide for DWS? I have no idea how to compile lets say the HTTP.sys Server. How do I have to configure the IDE to compile DWS Projects? – Sebastian Jan 09 '14 at 20:11
1

First of all make sure you downloaded the newest version from the main source, because DWScript 2.3 preview 1 is now available.

Then you must notice on this page that everyday you have changes on DWScript, so check where is the error (in which unit), then go to the source code page to take the most recent units.

Personally, it happened to me, and after I fixed some changes, it worked fine.

Zeina
  • 1,573
  • 2
  • 24
  • 34