Undefined index: when variables declared

Question

Ive looked through other posts with the same error but i get this error for every form i do where by a variable is the user input. Im having to create a 2 page process registration form, can anyone see were ive gone wrong thanks: < PHP:

 // Connection to server
 $db_host = "localhost";
 $db_username = "root";
 $db_pass = "password";
 $db_name = "members";
@mysql_connect ("$db_host","$db_username","$db_pass") or die ("Could not            connect to mysql");
@mysql_select_db("$db_name") or die ("No Database");

 //Variables
 $Username = $_POST['Username'];
 $password = md5 ($_POST['password']);
 $insert = 'INSERT into Members(Username, password,) VALUES ("'.$Username.'", "'        .$password.'")';

mysql_query($insert);

 ?>

And the form:
<body>
<form method= "post" action="reg.php">
 <table width="200" border="1">
  <tr>
 <td>Username</td>
<td><input type="text" name="Username" /></td>
</tr>
<tr>
<td>Password</td>
<td><input type="password" name"password" /></td>
</tr>
 <tr>
<td>&nbsp;</td>
<td><input type="submit" name"submit" value="Submit" /></td>
</tr>

</table>

I was told to use a isset function which i do so which did say the variable did exist.

Terrible question, because: 1. You are surpressing errors using `@`. 2. You didn't add the exact error. 3. Your script is vulnerable to SQLi. 4. You say you do `isset()`, but you don't. 5. You are using `md5()` which has been broken for a long time. — PeeHaa, Mar 25 '12 at 12:11
Someone call it terrible but in fact it's just PHP as it is. I'd wonder if I see any other code. — Your Common Sense, Mar 25 '12 at 12:13
Sorry literally started php last Thursday so getting to grips, all i know is through tutorials and guides. And the error is on $password. — Danny Shezo, Mar 25 '12 at 12:30

score 1 · Answer 1 · answered Mar 25 '12 at 12:12

1

You're missing a '=' here:

<td><input type="password" name"password" /></td>

Should be:

<td><input type="password" name="password" /></td>

answered Mar 25 '12 at 12:12

Michael

11,912
6
49
64

Ok just sorted that but still getting the error – Danny Shezo Mar 25 '12 at 12:28
What is the exact error message? It will tell you what line is the issue. What's on that line? – Michael Mar 25 '12 at 12:29

score -2 · Answer 2 · answered Mar 25 '12 at 12:12

-2

run your PHP part inside of

if ($_SERVER['REQUEST_METHOD'] == 'POST') {
... 
}

answered Mar 25 '12 at 12:12

Your Common Sense

156,878
40
214
345

Undefined index: when variables declared

2 Answers2