Insert into SQL Server table gives me nothing

Question

Very frustrating one... I have tried many combinations of ', " and so on but my insert command just refreshing the page.

What am I doing wrong?

Simple two text fields form with button. Under button I have this:

SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["przychodniaConnectionString1"].ConnectionString);
con.Open();

string cmdStr = "INSERT INTO specyfik(speNazwa, speIlosc) values ('" + speNazwa.Text + "', '" + speIlosc.Text + "')";
SqlCommand insertCmd = new SqlCommand(cmdStr, con);
con.Close();

Zero errors while compiling and when testing, it seems like refreshed page. Nothing appears in db.

score 4 · Accepted Answer · answered Mar 10 '12 at 16:24

4

Don't you need to call insertCmd.ExecuteNonQuery() ?

...
SqlCommand insertCmd = new SqlCommand(cmdStr, con); 
int row_affected = insertCmd.ExecuteNonQuery();
...

answered Mar 10 '12 at 16:24

a1ex07

36,826
12
90
103

score 4 · Answer 2 · answered Mar 10 '12 at 16:24

4

You need to execute your SqlCommand:

insertCmd.ExecuteNonQuery();

Also, you should look into parameterizing that query: http://www.codinghorror.com/blog/2005/04/give-me-parameterized-sql-or-give-me-death.html

answered Mar 10 '12 at 16:24

Mark S. Rasmussen

34,696
4
39
58

I need some way to +1 again the parameterizing sentence. – Damien_The_Unbeliever Mar 10 '12 at 16:30
Thank you! A habbit from php I guess, because I thought that SqlCommand insertCmd = new SqlCommand(cmdStr, con); will do a job ;) – dargod Mar 10 '12 at 16:39

score 0 · Answer 3 · edited May 23 '17 at 12:21

0

Will you like to make more improvements in your code using stored Proc and improvemnet in your code behind file ? Take a look at this answer...

https://stackoverflow.com/a/9595501/1209450

edited May 23 '17 at 12:21

Community

1
1

answered Mar 10 '12 at 17:30

Pankaj

9,749
32
139
283

Insert into SQL Server table gives me nothing

3 Answers3