Error while Overloading the '>>' operator

Question

I'm designing a Money object for a project. I'm not asking for help on implementation, because I really have to figure that out myself, but I'm getting the following error (and this is the only error!)

error C2678: binary '>>' : no operator found which takes a left-hand operand of type 'std::istream' (or there is no acceptable conversion)

I don't have errors in my Money.h or Money.cpp file, just the test.cpp file. Here are the contents of all three files:

Money.h

#ifndef MONEY_H
#define MONEY_H
#include <iostream>
#include <string>
class Money
{
public:
    Money( );
    Money( int dollars, int cents );

    friend std::istream& operator>>( std::istream &i, Money &m );

private:
    int dollars;
    int cents;
};
#endif

Money.cpp

#include "Money.h"

Money::Money(void) : dollars(0), cents(0)
{

}

Money::Money( int dollars, int cents ) : dollars(dollars), cents(cents)
{

}

std::istream& operator>>( std::istream &i, Money &m )
{

    int d;
    int c;
    char input;
    std::string dollars = "";
    std::string cents = "";

    input = std::cin.peek();
    while (std::cin.peek() != '.')
    {
        if ( !( (input >= '0') && (input <= '9') ) )
        {
            std::cin.ignore();
        }
        else
        {
            input = std::cin.get();
        }

        dollars += input;
    }

    if ( std::cin.peek() == '.')
    {
        std::cin.ignore();
    }

    std::cin >> cents;

    d = atoi(dollars.c_str());
    c = atoi(cents.c_str());

    m = Money(d, c);

    return i;
}

Finally, test.cpp:

#include "Money.h"

int main()
{
    Money newMoney();
    std::cout << "Enter a money object!" << std::endl;
    std::cin >> newMoney;
}

So, there you have it. I'm pretty sure that's about as trimmed-down as I can get it.

Instead of poking around google, try this: reduce your program to the smallest possible program that still exhibits the error. Either you'll discover the error in the process, or you have a useful test case to post to StackOverflow. http://sscce.org/ — Robᵩ, Mar 07 '12 at 21:45
Do you declare `std::istream& operator>>(std::istream& is, Money& m)` somewhere that your test code can see it? — Peter Wood, Mar 07 '12 at 21:50
I now have `friend std::istream& operator>>( std::istream &i, Money &m );` in my Money.h file, and the function is defined in the implementation file. I still have the same error. — Tasuret, Mar 07 '12 at 22:06

Robᵩ · Accepted Answer · 2012-03-07T22:25:22.793

2

You don't have enough data in the question. But, consulting my crystal ball, I see that you have defined operator>> in your .CPP file, but failed to declare operator>> in your .H.

Add the following line to your .H:

std::istream& operator>>( std::istream &i, Money &m );

My crystal ball is faulty. The error lies here:

Money newMoney();

That doesn't declare a Money object named newMoney. That declares an external function named newMoney that takes no paramaters and returns a Money object. Replace that line with this:

Money newMoney;

edited Mar 07 '12 at 22:25

answered Mar 07 '12 at 21:47

Robᵩ

163,533
20
239
308

I implemented yours and nate_weldon's answers, and I have pasted my code. – Tasuret Mar 07 '12 at 22:18
1

@Tasuret - if you had posted the stripped code when you first asked the question, you would have received a correct answer much sooner. – Robᵩ Mar 07 '12 at 22:27
Augh, I'm an idiot. I need to practice my C++, after taking 3 years of Java. – Tasuret Mar 07 '12 at 22:36

score 0 · Answer 2 · edited Mar 07 '12 at 22:18

0

Nothing pops out other than normally I would define this

std::istream& operator>>

as

friend std::istream& operator>>

edited Mar 07 '12 at 22:18

Mike Samuel

118,113
30
216
245

answered Mar 07 '12 at 22:01

nate_weldon

2,289
1
26
32

Error while Overloading the '>>' operator

2 Answers2