php add key with value to array faster way

Question

I have an array:

    $data = array(
        'loggedin' => false
    );

i want to add other keys as well their values if the user is logged in so i use:

    if ( $this->auth_model->loggedin()){//user is logged in
        $data["loggedin"] = true;//set to true
        $data["user_id"] = $this->session->userdata["uid"];//add new key with its value on $data array
    }

is this the best way to do it or should i use array_push and such?

Well, this is how you add values to an associative array. You can't really do this with `array_push()`. Also, speed does not really matter when you are adding two values to an almost empty array. Don't micro-optimize. — kapa, Feb 23 '12 at 09:26
your solution is faster, with array_push you will call functions, this is a overhead.... see at http://php.net/manual/de/function.array-push.php — silly, Feb 23 '12 at 09:28

score 3 · Accepted Answer · answered Feb 23 '12 at 09:30

3

No need to add overhead by calling a function (like array_push).

Yes. That's the way to do it.

answered Feb 23 '12 at 09:30

Andrei G

1,590
8
13

score 2 · Answer 2 · answered Feb 23 '12 at 09:26

2

With array_push you cannot set the key.

The way you have described is the fastest one.

You can create a second array with user_id key and then merge those two arrays, but this is not a good way to solve this case.

Stay with that you have right now.

answered Feb 23 '12 at 09:26

hsz

148,279
62
259
315

score 2 · Answer 3 · answered Feb 23 '12 at 09:27

2

i don't think you can use array_push to add values to an associative array, so it's ok to do as you are doing

answered Feb 23 '12 at 09:27

Nicola Peluchetti

76,206
31
145
192

score 1 · Answer 4 · edited Aug 28 '17 at 18:03

1

The way you are adding is better than using array_push (reason: you are inserting few values and it avoid the overhead of calling a function) if you are adding more values to this array, then you can use array_push.

edited Aug 28 '17 at 18:03

halfer

19,824
17
99
186

answered Feb 23 '12 at 09:34

Nishant

3,614
1
20
26

php add key with value to array faster way

4 Answers4