75

In PHP, I have an array of variables that are ALL strings. Some of the values stored are numeric strings with commas.

What I need:

A way to trim the commas from strings, and ONLY do this for numeric strings. This isn't as straightforward as it looks. The main reason is that the following fails:

$a = "1,435";

if(is_numeric($a))
    $a = str_replace(',', '', $a);

This fails because $a = "1435" is numeric. But $a = "1,435" is not numeric. Because some of the strings I get will be regular sentences with commas, I can't run a string replace on every string.

General Grievance
  • 4,555
  • 31
  • 31
  • 45
user1082428
  • 1,081
  • 3
  • 12
  • 14
  • use preg_replace to selectively replace commas that are enclosed on both sides by [0-9]? – Daan Feb 17 '12 at 20:28

8 Answers8

125

Do it the other way around:

$a = "1,435";
$b = str_replace( ',', '', $a );

if( is_numeric( $b ) ) {
    $a = $b;
}
JJJ
  • 32,902
  • 20
  • 89
  • 102
30

The easiest would be:

$var = intval(preg_replace('/[^\d.]/', '', $var));

or if you need float:

$var = floatval(preg_replace('/[^\d.]/', '', $var));
Jayela
  • 365
  • 1
  • 4
  • 7
27

Not tested, but probably something like if(preg_match("/^[0-9,]+$/", $a)) $a = str_replace(...)

Kenaniah
  • 5,171
  • 24
  • 27
  • Yes, this works. I tried all the string formats I would expect, and this works. Will mark as accepted answer once the site lets me. – user1082428 Feb 17 '12 at 20:32
  • If you want to remove commas from numbers inside a string that also contains words use this pattern if you want to avoid removing commas in words: /[0-9]+[,]+[0-9]+/ – Flaxious Sep 06 '17 at 18:30
  • This answer is not elegant. Why would you all `preg_match()` then `str_replace()` when it can be done with `preg_replace()` alone? – mickmackusa May 08 '20 at 01:41
10

It sounds like the ideal solution for what you're looking for is filter_var():

$a = filter_var($a, FILTER_VALIDATE_FLOAT, FILTER_FLAG_ALLOW_THOUSAND);

(Note that it's using FILTER_VALIDATE_FLOAT instead of FILTER_VALIDATE_INT because that one doesn't currently have a FILTER_FLAG_ALLOW_THOUSAND option).

orrd
  • 9,469
  • 5
  • 39
  • 31
7

Try this .this worked for me

number_format(1235.369,2,'.','')

if you use number_format like this number_format(1235.369,2) answer will be 1,235.37

but if you use like below

number_format(1235.369,2,'.','') answer will be 1235.37

it's removing the "," of "1,235.37"

Meloman
  • 3,558
  • 3
  • 41
  • 51
kaushi
  • 153
  • 1
  • 5
  • 2
    Works! But the question is about removing commas from **existing numeric strings** and not to format it on **any numeric value**. If you try `number_format('1,235.369',2,'.','')`, it won't work. – Nikhil Bhatia Sep 26 '19 at 07:05
2
 function cleanData($a) {

     if(is_numeric($a)) {

     $a = preg_replace('/[^0-9,]/s', '', $a);
     }

     return $a;

}
Ryan
  • 14,392
  • 8
  • 62
  • 102
  • The OP has stated that `$a = "1,435" is not numeric`. So this answer will fail. This answer is also low value because there is no explanation of how it works or why it is a good idea. – mickmackusa May 08 '20 at 01:44
1

If you want to remove commas from numbers inside a string that also contains words, the easiest way I think would be to use preg_replace_callback:

Example:  

$str = "Hey hello, I've got 12,500 kudos for you, spend it well"

function cleannr($matches)
{
    return str_replace("," , "" , $matches["nrs"]);
}

$str = preg_replace_callback ("/(?P<nrs>[0-9]+,[0-9]+)/" , "cleannr" , $str);


Output:

"Hey hello, I've got 12500 kudos for you, spend it well"


In this case the pattern (regex) differs from the one given in the accepted answer since we don't want to remove the other commas (punctuation).

If we'd use /[0-9,]+/ here instead of /[0-9]+,[0-9]+/ the output would be:

"Hey hello I've got 12500 kudos for you spend it well"

Flaxious
  • 101
  • 1
  • 3
1

How about this:

/**
 * This will parse the money string
 * 
 * For example 1, 234, 456.00 will be converted to 123456.00
 * 
 * @return 
 */
function parseMoney(string $money) : float
{
    $money = preg_replace('/[ ,]+/', '', $money);
    return number_format((float) $money, 2, '.', '');
}

Example;

parseMoney('-1, 100,   000.01'); //-1100000.01
Emeka Mbah
  • 16,745
  • 10
  • 77
  • 96