13

I have a rails controller with two actions defined: index and show. I have an instance variable defined in index action. The code is something like below:

def index
  @some_instance_variable = foo
end

def show
  # some code
end

How can I access the @some_instance_variable in show.html.erb template?

Adobe
  • 12,967
  • 10
  • 85
  • 126
imran
  • 626
  • 2
  • 13
  • 24

2 Answers2

59

You can define instance variables for multiple actions by using a before filter, e.g.:

class FooController < ApplicationController
  before_filter :common_content, :only => [:index, :show]

  def common_content
    @some_instance_variable = :foo
  end
end

Now @some_instance_variable will be accessible from all templates (including partials) rendered from the index or show actions.

Mori
  • 27,279
  • 10
  • 68
  • 73
  • @Mori How would you go about deciding whether to place the method/object in private or protected or public space? Thks! – pyfork Feb 12 '16 at 08:29
  • 3
    Just for future readers. DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. – evgeny May 05 '17 at 23:55
14

Unless you're rendering show.html.erb from the index action, you'll need to set @some_instance_variable in the show action as well. When a controller action is invoked, it calls the matching method -- so the contents of your index method will not be called when using the show action.

If you need @some_instance_variable set to the same thing in both the index and show actions, the correct way would be to define another method, called by both index and show, that sets the instance variable.

def index
  set_up_instance_variable
end

def show
  set_up_instance_variable
end

private

def set_up_instance_variable
  @some_instance_variable = foo
end

Making the set_up_instance_variable method private prevents it from being called as a controller action if you have wildcard routes (i.e., match ':controller(/:action(/:id(.:format)))')

Emily
  • 17,813
  • 3
  • 43
  • 47