XmlDocument Save keeps file open

Question

I have a simple c# function that creates a basic XML file and saves:

private void CreateXMlFile(string Filename, string Name, string Company)
        {
            XmlDocument doc = new XmlDocument();
            XmlNode docNode = doc.CreateXmlDeclaration("1.0", "UTF-8", null);
            doc.AppendChild(docNode);

            XmlNode licenseNode = doc.CreateElement("license");
            doc.AppendChild(licenseNode);

            XmlNode node = doc.CreateElement("Name");
            node.AppendChild(doc.CreateTextNode(Name));
            licenseNode.AppendChild(node);

            node = doc.CreateElement("Company");
            node.AppendChild(doc.CreateTextNode(Company));
            licenseNode.AppendChild(node);


            doc.Save(Filename);
        }

When I try to edit or delete the file I always get following error:

The process cannot access the file because it is being used by another process.

XmlDocument doesnt have any inbuilt dispose or close routines and wondered how I can force the file to close before later editing or deleting it.

I have tried to save the file using StreamWriter:

StreamWriter outStream = System.IO.File.CreateText(outfile);
            outStream.Write(data);
            outStream.Close();

But this didnt make a difference with the same error.

Your advice is greatly accepted.

Thank you

Have you tried to write it with an instance of a stream write instead of passing the file name to save? — Steve, Feb 17 '12 at 11:01
I had the same problem, but my code was loading the XML first if it existed. The `XmlReader` object needed to be closed before the lock on the file was freed. — Arnold Pistorius, Apr 21 '15 at 06:59

AshokD · Answer 1 · 2012-02-17T12:09:50.340

7

Send Stream to XmlDocument's Save method instead of file name.

    private static void Main(string[] args)
    {
        CreateXMlFile("c:\\test.xml", "testName", "testCompany");
    }

    private static void CreateXMlFile(string Filename, string Name, string Company)
    {
        XmlDocument doc = new XmlDocument();
        XmlNode docNode = doc.CreateXmlDeclaration("1.0", "UTF-8", null);
        doc.AppendChild(docNode);

        XmlNode licenseNode = doc.CreateElement("license");
        doc.AppendChild(licenseNode);

        XmlNode node = doc.CreateElement("Name");
        node.AppendChild(doc.CreateTextNode(Name));
        licenseNode.AppendChild(node);

        node = doc.CreateElement("Company");
        node.AppendChild(doc.CreateTextNode(Company));
        licenseNode.AppendChild(node);
        StreamWriter outStream = System.IO.File.CreateText(Filename);

        doc.Save(outStream);
        outStream.Close();
    }

I tried executing above code and it is working fine at my end.

edited Feb 17 '12 at 12:09

answered Feb 17 '12 at 11:20

AshokD

442
4
14

I tried this and when I go to delete the file I get same error. – Belliez Feb 17 '12 at 11:43
Can you try changing the file location? – AshokD Feb 17 '12 at 11:52
tried new location also and same. I also disabled Livedrive (online backup) in case this was interfering. – Belliez Feb 17 '12 at 11:58
1

This problem has been dogging me for a couple days as XMLDocument.Save() seems to flush properly when in debug mode however when in Release it does not. Using a Stream solved the problem, thank you. – StuTheDog Aug 09 '12 at 19:23
Have you eventually figured it out? I currently have the same problem. – Ravid Goldenberg Nov 05 '15 at 14:11

score 2 · Answer 2 · answered Feb 17 '12 at 11:17

2

Your code is fine. I tested it on my machine and there is no lock left after Save().

Try to use Unlocker (http://www.softpedia.com/get/System/System-Miscellaneous/Unlocker.shtml) to check whether you are really the one who holds the lock.

Which .NET framework do you use? Theres also a report (http://bytes.com/topic/net/answers/467028-xmldocument-save-does-not-close-file-properly) which was not reproducable too.

answered Feb 17 '12 at 11:17

BlueM

6,523
1
25
30

Its being locked by the visual studio vshost.exe. I just compiled to .net 3.5 and same problem. – Belliez Feb 17 '12 at 11:55
Could you create a blank project with that method called by a button click and check after the click whether the file is locked? – BlueM Feb 17 '12 at 12:27

XmlDocument Save keeps file open

2 Answers2

Linked