How can I continue The upper Loop

Question

I have this code:

foreach(int i in Directions)
        {
            if (IsDowner(i))
            {
                while (IsDowner(i))
                {
                    continue;
                    //if (i >= Directions.Count)
                    //{
                    //    break;
                    //}
                }

                //if (i >= Directions.Count)
                //{
                //    break;
                //}

                if (IsForward(i))
                {

                        continue;
                        //if (i >= Directions.Count)
                        //{
                        //    break;
                        //}

                    //check = true;
                }

                //if (i >= Directions.Count)
                //{
                //    break;
                //}

                if (IsUpper(i))
                {
                        //if (i >= Directions.Count)
                        //{
                        //    break;
                        //}
                    num++;
                    //check = false;
                }

                //if (check)
                //{
                //    num++;
                //}
            }
        }

but I want to have continue for foreach in while loop. how can I do this?

Related: http://stackoverflow.com/questions/8497247/break-nested-loops — CodesInChaos, Feb 05 '12 at 10:03

score 9 · Answer 1 · answered Feb 05 '12 at 10:07

You cannot continue an outer loop from an inner one. You have two options:

The bad one: set a boolean flag before breaking the inner loop, then check this flag and continue if it is set.
The good one: simply refactor your big spagetti code into a set of functions so you do not have inner loops.

Darin Dimitrov · Accepted Answer · 2012-02-05T10:01:15.910

6

You could break out of the while loop and move on to the next iteration of the outer foreach loop which will start a new while loop:

foreach(int i in Directions)
{
    while (IsDowner(i))
    {
        break;
    }
}

If you had some other code after the while loop that you don't want to be executed in this case you could use a boolean variable which will be set before breaking out of the while loop so that this code doesn't execute and automatically jump on the next iteration of the forach loop:

foreach(int i in Directions)
{
    bool broken = false;
    while (IsDowner(i))
    {
        // if some condition =>
        broken = true;
        break;
    }

    if (broken) 
    {
        // we have broken out of the inner while loop
        // and we don't want to execute the code afterwards
        // so we are continuing on the next iteration of the
        // outer foreach loop
        continue;
    }

    // execute some other code
}

edited Feb 05 '12 at 10:01

answered Feb 05 '12 at 09:52

Darin Dimitrov

1,023,142
271
3,287
2,928

but I have another codes after while loop and I want to have them and with next foreach variable(i). – ahmadali shafiee Feb 05 '12 at 09:55
@ahmadalishafiee, you could use a boolean variable. – Darin Dimitrov Feb 05 '12 at 09:56
question edited. but with your way there is many Nested if in my code – ahmadali shafiee Feb 05 '12 at 09:57
1

instead using `if(!broken) {...}` you can use `if(broken) continue;` – Piotr Auguscik Feb 05 '12 at 09:59
@ahmadalishafiee, you cannot `continue` the outer loop from an inner loop. You will first need to break out of the inner loop. Also as Piotr Auguscik suggested you could invert the condition. I have updated my answer with an example. – Darin Dimitrov Feb 05 '12 at 09:59

laroley · Answer 3 · 2012-02-05T10:31:15.797

In my opinion, using goto is justifiable within complex nested loops (whether or not you should avoid using complex nested loops is a different question).

You could do this:

foreach(int i in Directions)
{
    while (IsDowner(i))
    {
        goto continueMainLoop;
    }
    //There be code here
continueMainLoop:
}

Just be careful if other people have to deal with the code, make sure they're not goto-phobic.

score 0 · Answer 4 · answered Sep 23 '15 at 09:35

you could try to use predicates for the inner for loop like:

    foreach (item it in firstList)
     {
        if (2ndList.Exists(x => it.Name.StartsWith(x))) //use predicate instead of for loop.
            {
                continue;
            } 
     }

Hope this helps you.

How can I continue The upper Loop

4 Answers4