56

I need to rename indentifier in this:

{ "general" : 
  { "files" : 
    { "file" : 
      [  
        {  "version" : 
          {  "software_program" : "MonkeyPlus",      
             "indentifier" : "6.0.0" 
          } 
        } 
      ] 
    } 
  } 
}

I've tried

db.nrel.component.update(
  {},
  { $rename: {
    "general.files.file.$.version.indentifier" : "general.files.file.$.version.identifier"
  } },
  false, true
)

but it returns: $rename source may not be dynamic array.

Dan Dascalescu
  • 143,271
  • 52
  • 317
  • 404
Andrew Samuelsen
  • 5,325
  • 9
  • 47
  • 69

8 Answers8

56

For what it's worth, while it sounds awful to have to do, the solution is actually pretty easy. This of course depends on how many records you have. But here's my example:

db.Setting.find({ 'Value.Tiers.0.AssetsUnderManagement': { $exists: 1 } }).snapshot().forEach(function(item)
{    
    for(i = 0; i != item.Value.Tiers.length; ++i)
    {
        item.Value.Tiers[i].Aum = item.Value.Tiers[i].AssetsUnderManagement;
        delete item.Value.Tiers[i].AssetsUnderManagement;
    }
    
    db.Setting.update({_id: item._id}, item);
});

I iterate over my collection where the array is found and the "wrong" name is found. I then iterate over the sub collection, set the new value, delete the old, and update the whole document. It was relatively painless. Granted I only have a few tens of thousands of rows to search through, of which only a few dozen meet the criteria.

Still, I hope this answer helps someone!

Edit: Added snapshot() to the query. See why in the comments.

You must apply snapshot() to the cursor before retrieving any documents from the database. You can only use snapshot() with unsharded collections.

From MongoDB 3.4, snapshot() function was removed. So if using Mongo 3.4+ ,the example above should remove snapshot() function.

turivishal
  • 34,368
  • 7
  • 36
  • 59
Eli Gassert
  • 9,745
  • 3
  • 30
  • 39
  • 3
    Imho this should be the accepted answer. I performed this approach on several collections with up to twelve million documents each and it worked like a charm! – Sander Toonen Jul 27 '15 at 10:19
  • 2
    Absolutely. This works great. A pity MongoDB is not able yet to include this behaviour natively. – Faliorn Oct 03 '15 at 12:06
  • 2
    It's better to use snapshot(): `db.Setting.find({ 'Value.Tiers.0.AssetsUnderManagement': { $exists: 1 } }).snapshot().forEach(...)` Otherwise you can end up in an infinite loop. See also https://docs.mongodb.org/v3.0/reference/method/cursor.snapshot/ – Patrycja K Jan 19 '16 at 14:58
  • New one to me. Thanks for the details, @PatrycjaK! Updating my answer. – Eli Gassert Jan 19 '16 at 15:12
  • @Andrew Samuelsen I think this should be the selected answer - a script to work around the "by design" problem – NoamG Jul 18 '18 at 12:30
  • @PatrycjaK: [`snapshot` is deprecated](https://mongodb.github.io/node-mongodb-native/3.1/api/Cursor.html#snapshot) as of MongoDB 4.0. – Dan Dascalescu Jun 12 '19 at 09:09
26

As mentioned in the documentation there is no way to directly rename fields within arrays with a single command. Your only option is to iterate over your collection documents, read them and update each with $unset old/$set new operations.

Cardinal System
  • 2,749
  • 3
  • 21
  • 42
Remon van Vliet
  • 18,365
  • 3
  • 52
  • 57
21

I had a similar problem. In my situation I found the following was much easier:

  1. I exported the collection to json:
mongoexport --db mydb --collection modules --out modules.json
  1. I did a find and replace on the json using my favoured text editing utility.

  2. I reimported the edited file, dropping the old collection along the way:

mongoimport --db mydb --collection modules --drop --file modules.json
Alexander Vogt
  • 17,879
  • 13
  • 52
  • 68
fraccy
  • 251
  • 2
  • 3
  • 3
    I'm kinda skeptical how well this approach works on a large dataset. Say my db is 5gb, this process sounds slow. Or perhaps I'm not using the right text editing tools =-} – Matthew Bonig Oct 13 '15 at 19:42
  • 3
    Also be cautious of live databases. If records get added/modified in the time it takes to do these steps, changes will be lost. – Eli Gassert Jan 18 '16 at 11:16
  • This is okay if you have something that only runs on your laptop but isn't a viable solution if you're working in a production environment. – Valerie R. Coffman Jul 12 '19 at 01:03
20

Starting Mongo 4.2, db.collection.update() can accept an aggregation pipeline, finally allowing the update of a field based on its own value:

// { general: { files: { file: [
//   { version: { software_program: "MonkeyPlus", indentifier: "6.0.0" } }
// ] } } }
db.collection.updateMany(
  {},
  [{ $set: { "general.files.file": {
       $map: {
         input: "$general.files.file",
         as: "file",
         in: {
           version: {
             software_program: "$$file.version.software_program",
             identifier: "$$file.version.indentifier" // fixing the typo here
           }
         }
       }
  }}}]
)
// { general: { files: { file: [
//   { version: { software_program: "MonkeyPlus", identifier: "6.0.0" } }
// ] } } }

Literally, this updates documents by (re)$setting the "general.files.file" array by $mapping its "file" elements in a "version" object containing the same "software_program" field and the renamed "identifier" field which contains what used to be the value of "indentifier".


A couple additional details:

  • The first part {} is the match query, filtering which documents to update (in this case all documents).

  • The second part [{ $set: { "general.files.file": { ... }}}] is the update aggregation pipeline (note the squared brackets signifying the use of an aggregation pipeline):

    • $set is a new aggregation operator which in this case replaces the value of the "general.files.file" array.
    • Using a $map operation, we replace all elements from the "general.files.file" array by basically the same elements, but with an "identifier" field rather than "indentifier":
    • input is the array to map.
    • as is the variable name given to looped elements
    • in is the actual transformation applied on elements. In this case, it replaces elements by a "version" object composed by a "software_program" and a "identifier" fields. These fields are populated by extracting their previous values using the $$file.xxxx notation (where file is the name given to elements from the as part).
Pete B
  • 1,709
  • 18
  • 11
Xavier Guihot
  • 54,987
  • 21
  • 291
  • 190
  • 2
    You were keep `software_program` manually. But what if version field has alot of children fields, and may be difference fields in each documents? – Haidang Nguyen Jun 18 '20 at 07:45
  • To answer @HaidangNguyen's question, and in general a good practice - use `$mergeObjects` in `$map`'s `in` :) In the case of the example above: `in: { $mergeObjects: ['$$file', / * changes here */] }`. – Amit Beckenstein Jan 06 '22 at 13:18
11

I had to face the issue with the same schema. So this query will helpful for someone who wants to rename the field in an embedded array.

db.getCollection("sampledocument").updateMany({}, [
  {
    $set: {
      "general.files.file": {
        $map: {
          input: "$general.files.file",
          in: {
            version: {
              $mergeObjects: [
                "$$this.version",
                { identifer: "$$this.version.indentifier" },
              ],
            },
          },
        },
      },
    },
  },
  { $unset: "general.files.file.version.indentifier" },
]);

Another Solution

6

I also would like rename a property in array: and I used thaht

db.getCollection('YourCollectionName').find({}).snapshot().forEach(function(a){
    a.Array1.forEach(function(b){
        b.Array2.forEach(function(c){
            c.NewPropertyName = c.OldPropertyName;
            delete c["OldPropertyName"];                   
        });
    });
    db.getCollection('YourCollectionName').save(a)  
});
Cedric Michel
  • 502
  • 5
  • 13
2

The easiest and shortest solution using aggregate (Mongo 4.0+).

db.myCollection.aggregate([
  {
    $addFields: {
      "myArray.newField": {$arrayElemAt: ["$myArray.oldField", 0] }
    }
  },
  {$project: { "myArray.oldField": false}},
  {$out: {db: "myDb", coll: "myCollection"}}
])

The problem using forEach loop as mention above is the very bad performance when the collection is huge.

loonis
  • 1,317
  • 16
  • 19
1

My proposal would be this one:

db.nrel.component.aggregate([
   { $unwind: "$general.files.file" },
   {
      $set: {
         "general.files.file.version.identifier": {
            $ifNull: ["$general.files.file.version.indentifier", "$general.files.file.version.identifier"]
         }
      }
   },
   { $unset: "general.files.file.version.indentifier" },
   { $set: { "general.files.file": ["$general.files.file"] } },
   { $out: "nrel.component" } // carefully - it replaces entire collection.
])

However, this works only when array general.files.file has a single document only. Most likely this will not always be the case, then you can use this one:

db.nrel.componen.aggregate([
   { $unwind: "$general.files.file" },
   {
      $set: {
         "general.files.file.version.identifier": {
            $ifNull: ["$general.files.file.version.indentifier", "$general.files.file.version.identifier"]
         }
      }
   },
   { $unset: "general.files.file.version.indentifier" },
   { $group: { _id: "$_id", general_new: { $addToSet: "$general.files.file" } } },
   { $set: { "general.files.file": "$general_new" } },
   { $unset: "general_new" },
   { $out: "nrel.component" } // carefully - it replaces entire collection.
])
Wernfried Domscheit
  • 54,457
  • 9
  • 76
  • 110