Memory leak when parse JSON string using SBJSON

Question

I am using following code to parse JSON and getting memory leak (100%) on line number 2. I don't know what is the problem, can someone help me ?

    NSString *response = [request responseString];
    NSMutableDictionary *responseJSON = [response JSONValue]; (100% leak)

    NSString *tockenString = [responseJSON objectForKey:@"Token"];
    NSString *userIDString = [responseJSON objectForKey:@"ID"];

Are you using the latest release of SBJSON from github? Have you tried using an alternative JSON parser like KSJSON? Have you used Instruments to determine which code path causes the leak? — warrenm, Jan 16 '12 at 19:13
I am using latest release of SBJSON. I did not use KSJSON before. — AAV, Jan 16 '12 at 19:18
Either you've got a bogus copy of SBJSON or you're misinterpreting the diagnostics. — Hot Licks, Jan 16 '12 at 19:31

score 1 · Accepted Answer · answered Jan 16 '12 at 22:47

1

I found the answer. Go to SBJsonParser.m function scanRestOfString and change the line

from

        *o = [[NSMutableString alloc] initWithBytes:(char*)c length:len encoding:NSUTF8StringEncoding];

to

        *o = [[[NSMutableString alloc] initWithBytes:(char*)c length:len encoding:NSUTF8StringEncoding] autorelease];

SBJsonParser has a like in scanRestOfString/NSMutableString. I reported the bug as well. Thank you all.

answered Jan 16 '12 at 22:47

AAV

3,785
8
32
59

1

Seems odd that you would happen upon a bug in such a well-used piece of code. – Hot Licks Jan 17 '12 at 00:43
1

Even i found it odd. But when i implemented the changes, i didn’t get any leak from instrument analysis. – AAV Jan 17 '12 at 00:52

score 0 · Answer 2 · answered Jan 16 '12 at 18:38

0

Remove those 2 autoreleases. They overrelease the objects.

answered Jan 16 '12 at 18:38

Felix

35,354
13
96
143

score 0 · Answer 3 · answered Jan 16 '12 at 20:25

0

I've had a similar problem but it turned out the leak was actually higher in the chain of methods, but Instruments was (mistakenly) pointing to this line. Look at the methods that store the results retrieved from this code.

answered Jan 16 '12 at 20:25

Radu Lucaciu

706
3
6

Memory leak when parse JSON string using SBJSON

3 Answers3