Javascript issue in Django plugin

Question

I'm going to use django-threadedcomments library at my Django project.
https://github.com/HonzaKral/django-threadedcomments

The tutorial gives sample code, including Javascript to reply to comments in threaded-comment style.
I've tried to test this sample, and the library works itself but the Javascript to reply to comments doesn't work.
And there's nothing wrong with jQuery loading or with Django static files loading.

This is the tutorial. http://goo.gl/vyFw9

I'm wondering:
1)Is there anything wrong with the script?
2)If not, any ideas as to why this doesn't work?

function show_reply_form(comment_id, url, person_name) {
var comment_reply = $('#' + comment_id);
var to_add = $( new Array(
'<div class="response"><p>Reply to ' + person_name + ':</p>',
'<form method="POST" action="' + url + '">',
'<ul>',  '{{ form.as_ul|oneline }}',
'<li><input type="submit" value="Submit Comment" /></li>',
'</ul>', '</form>', '</div>').join(''));
to_add.css("display", "none");
comment_reply.after(to_add);
to_add.slideDown(function() {
    comment_reply.replaceWith(new Array('<a id="',
    comment_id,'" href="javascript:hide_reply_form(\'',
    comment_id, '\',\'', url, '\',\'', person_name,
    '\')">Stop Replying</a>').join(''));
});
}
function hide_reply_form(comment_id, url, person_name) {
var comment_reply = $('#' + comment_id);
comment_reply.next().slideUp(function (){
    comment_reply.next('.response').remove();
    comment_reply.replaceWith(new Array('<a id="',
    comment_id,'" href="javascript:show_reply_form(\'',
    comment_id, '\',\'', url, '\',\'', person_name,
    '\')">Reply</a>').join(''));
});
}

<a id="c{{ comment.id }}" href="javascript:show_reply_form('c{{ comment.id }}','{% get_free_comment_url post comment %}','{{ comment.name }}')">Reply</a>

Can you copy in any Javascript errors you're getting from your browser's error console? Press F12 in Chrome or Firefox with Firebug installed. Ctrl-Shift-J will get you there in Firefox sans Firebug. — Hal, Jan 10 '12 at 08:13
@harrison_m Thanks, I got "show_reply_form is not defined" at error console. — koichi_n, Jan 10 '12 at 09:14

Sandeep · Accepted Answer · 2012-01-10T08:22:50.270

0

First thing I see is that you are not appending to_add to the document at all, i.e something like $('#someExistingDiv').append(to_add);

After creating the to_add, it has to be added to the DOM. I don't think there are any JS errors. I'm pretty sure it you are just not seeing the new comment element created.

edited Jan 10 '12 at 08:22

answered Jan 10 '12 at 08:16

Sandeep

819
10
16

Thanks! I got "show_reply_form is not defined" at error console when I call JS. Maybe this isn't JS error. – koichi_n Jan 10 '12 at 09:13
It seems to be not scoped properly. Try this: `Reply` – Sandeep Jan 10 '12 at 10:32
Thanks @Sandeep I've tried: Reply but got the same error... – koichi_n Jan 10 '12 at 18:01
Just asking, where is your javascript? Is it in on the page in a script tag? – Sandeep Jan 10 '12 at 20:08
Yes, it is on the same page in a script tag. And the page has the link to jquery file, the same version as sample. I tried some other scripts instead and they worked, so I think nothing wrong with settings. – koichi_n Jan 11 '12 at 04:00
And I can get a correct link to the comment like: Reply So, this isn't JS error, it could be a problem on Django template. – koichi_n Jan 11 '12 at 04:10

Javascript issue in Django plugin

1 Answers1