1

I have a timer and I want to know if its efficient or not to test if it's the first time the timer raise the elapsed event or not (I want change the Interval property after the first time the Elapsed event is raised) 

        _timer = new Timer(1000);
        _timer.Elapsed += 
            (src, e) =>
            {
                FireTrigger(this, EventArgs.Empty);
                if (isfirstTimeElapsed) // necessary ??
                {
                    _timer.Interval = 5000
                    isfirstTimeElapsed = false;
                }
            };

In term of performances what's the best choice ? test or not ?

Florian
  • 4,507
  • 10
  • 53
  • 73

2 Answers2

3

Its certainly not useless, it is self documenting code that means anybody reading it immediately understands that you want to change the interval on the first run. If you skipped the if and just set the interval every time it might not be obvious why you were doing this. As far as efficiency is concerned I doubt you'd notice a difference but of course if you are worried then perform some tests.

Chris
  • 27,210
  • 6
  • 71
  • 92
2

You can use System.Threading.Timer, in which you can set when first event should be fired, and the other ones

Arsen Mkrtchyan
  • 49,896
  • 32
  • 148
  • 184
  • Ok, there is no other impact to use System.Threading.Timer instead of System.Timers.Timer ? – Florian Dec 22 '11 at 09:55
  • 1
    http://msdn.microsoft.com/en-us/magazine/cc164015.aspx is an article on comparing the three different .NET timer classes. I suspect that may answer your questions. It depends on what you're doing with it as to which may be best. – Chris Dec 22 '11 at 10:03