Getting Filename from url in C#

Question

Currently we have a solution that grabs the filename from the URL using this

currentFile = Path.GetFileNameWithoutExtension(url);

We found that if there are query strings attached that include characters such as quotes it returns with an error of Illegal characters in path.

For example if the url is

http:\\myurl.com\mypage.aspx?utm_content=This+Is+"Broken"

Then it won't get the filename. Is there a better, cleaner way to get "mypage"?

Can't you just remove the query string from the url before calling GetFileNameWithoutExtension? — G_P, Dec 14 '11 at 20:39
check this one: http://stackoverflow.com/a/6015377/559144 and vote him up if it solves your issue ;-) — Davide Piras, Dec 14 '11 at 20:39
did you try Server.UrlEncode(url); before getting the file name ? — A.B.Cade, Dec 14 '11 at 20:41
Possible duplicate: http://stackoverflow.com/questions/3833680/asp-net-get-physical-filepath-from-url — M.Babcock, Dec 14 '11 at 20:41
Please consider that URLs need not refer to files, and that names with no illegal characters can still be illegal filenames. — Dour High Arch, Dec 14 '11 at 20:51

score 20 · Accepted Answer · answered Dec 14 '11 at 20:41

20

use this: Uri.AbsolutePath

Request.Url.AbsolutePath

answered Dec 14 '11 at 20:41

Davide Piras

43,984
10
98
147

22

`string filename = Path.GetFileName(new Uri(myUrlString).AbsolutePath);` – jocull Oct 31 '12 at 04:27

score 3 · Answer 2 · answered Dec 14 '11 at 20:39

3

I would just find the ? and if it exists, strip the rest of the string, then use that to GetFileNameWithoutExtension.

For example:

        string url;
        int index;

        index = url.IndexOf("?");
        if (index != -1)
        {
            url = url.Substring(0, index);
        }
        currentFile = Path.GetFileNameWithoutExtension(url);

answered Dec 14 '11 at 20:39

competent_tech

44,465
11
90
113

this is way more complicated and verbose than what the framework already offers: Request.Url.AbsolutePath – Davide Piras Dec 14 '11 at 20:57
1

@DavidePiras: Why are you assuming that the URL being processed is the request url? The OP made no mention of this in the initial question. The solution I provided was a direct response to their posted code which only referenced a URL. This url could be from a log file, it could be from a referral string, or from a parsed HTML page with embedded references. – competent_tech Dec 14 '11 at 21:01

score 0 · Answer 3 · answered Dec 14 '11 at 20:41

0

use HttpContext.Current.Request.PhysicalPath instead of the full URL as parameter into the Path.GetFileNameWithoutExtension method.

Hope this helps,

answered Dec 14 '11 at 20:41

Marvin Smit

4,088
1
22
21

Getting Filename from url in C#

3 Answers3