Python: how to make a recursive generator function

Question

I have been working on generating all possible submodels for a biological problem. I have a working recursion for generating a big list of all the submodels I want. However, the lists get unmanageably large pretty fast (N=12 is just possible in the example below, N>12 uses too much memory). So I wanted to convert it to a generator function using yield instead, but I'm stuck.

My working recursive function looks like this:

def submodel_list(result, pat, current, maxn):
    ''' result is a list to append to
        pat is the current pattern (starts as empty list)
        current is the current number of the pattern
        maxn is the number of items in the pattern
    '''
    if pat:
        curmax = max(pat)
    else: 
        curmax = 0
    for i in range(current):
        if i-1 <= curmax:
            newpat = pat[:]
            newpat.append(i)
            if current == maxn:
                result.append(newpat)
            else:
                submodel_generator(result, newpat, current+1, maxn)

result = []
submodel_list(result, [], 1, 5)

That gives me the expected list of submodels for my purposes.

Now, I want to get that same list using a recursion. Naively, I thought I could just switch out my result.append() for a yield function, and the rest would work OK. So I tried this:

def submodel_generator(pat, current, maxn):
    '''same as submodel_list but yields instead'''
    if pat:
        curmax = max(pat)
    else: 
        curmax = 0
    for i in range(current):
        print i, current, maxn
        if i-1 <= curmax:
            print curmax

            newpat = pat[:]
            newpat.append(i)
            if current == maxn:
                yield newpat
            else:
                submodel_generator(newpat, current+1, maxn)

b = submodel_generator([], 1, 5)
for model in b: print model

But now I get nothing. A (very dumb) bit of digging tells me the function gets to the final else statement once, then stops - i.e. the recursion no longer works.

Is there a way to turn my first, clunky, list-making function into a nice neat generator function? Is there something silly I've missed here? All help hugely appreciated!

possible duplicate of [Python: using a recursive algorithm as a generator](http://stackoverflow.com/questions/248830/python-using-a-recursive-algorithm-as-a-generator) — senderle, Dec 06 '11 at 22:29
In Python 3.3 you can use `yield from submodel_generator(...)`. Coming soon... — Dietrich Epp, Dec 06 '11 at 22:31
@senderle I agree it's very similar in nature to that post, but unfortunately I'm not good enough at Python to be able to understand what it was that made that one work, so I thought I'd post my similar example anyway, in the hopes of some much needed help! — roblanf, Dec 06 '11 at 23:07
The cool thing about `yield from` is that unlike `for ... yield` it properly handles generator's `.send()` and `.throw()` methods. — yak, Dec 06 '11 at 23:32
@roblanf, I understand--it's nothing personal. I just went with my gut. The vote to close will disappear if nobody agrees with me. — senderle, Dec 06 '11 at 23:47

jterrace · Accepted Answer · 2013-04-01T22:33:03.983

26

You should change this:

submodel_generator(newpat, current+1, maxn)

to this:

for b in submodel_generator(newpat, current+1, maxn):
    yield b

This will recursively yield the value from successive calls to the function.

[Update]: Note that as of Python 3.3, you can use the new yield from syntax:

yield from submodel_generator(newpat, current+1, maxn)

edited Apr 01 '13 at 22:33

answered Dec 06 '11 at 22:27

jterrace

64,866
22
157
202

Python: how to make a recursive generator function

1 Answers1

Linked