52

I have a model field, which stores a list of URLs (yeah, I know, that's wrong way) as url1\nurl2\nurl3<...>. I need to split the field into an array in my template, so I created the custom filter:

@register.filter(name='split')
def split(value, arg):
    return value.split(arg)

I use it this way:

{% with game.screenshots|split:"\n" as screens %}
        {% for screen in screens %}
            {{ screen }}<br>
        {% endfor %}
    {% endwith %}

but as I can see, split doesn't want to work: I get output like url1 url2 url3 (with linebreaks if I look at the source). Why?

Jonny
  • 3,807
  • 8
  • 31
  • 48
artem
  • 16,382
  • 34
  • 113
  • 189

5 Answers5

103

Django intentionally leaves out many types of templatetags to discourage you from doing too much processing in the template. (Unfortunately, people usually just add these types of templatetags themselves.)

This is a perfect example of something that should be in your model not your template.

class Game(models.Model):
    ...
    def screenshots_as_list(self):
        return self.screenshots.split('\n')

Then, in your template, you just do:

{% for screen in game.screenshots_as_list %}
    {{ screen }}<br>
{% endfor %}

Much more clear and much easier to work with.

christophe31
  • 6,359
  • 4
  • 34
  • 46
Chris Pratt
  • 232,153
  • 36
  • 385
  • 444
  • 5
    Keep in mind, though, that excessively fat models can become a pile of unmaintainable stuff. This specific case is valid—you'd be converting some of your serialized data to Python, which makes sense to do on the model layer. (You can even make that method a computed property.) However, if you want to put a method on your model *just* so that you can call it from your template, think twice—maybe it'd be OK to do that kind of processing in your view(s) :) – Anton Strogonoff Sep 18 '14 at 04:04
  • 1
    better than template tags if content is from models.Model – WeizhongTu Jun 24 '15 at 03:24
  • Great! Works for me! – Wason Oct 26 '21 at 06:26
  • This answer is an excellent suggestion. Thank you! I need a further suggestion: since such a method is quite similar in functionality to a "getter" function, would you much prefer this method to be defined `@property` or keep it as a method? – Rifaz Nahiyan Oct 23 '22 at 17:38
16

Functionality already exists with linkebreaksbr:

{{ value|linebreaksbr }}

https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#linebreaksbr

peterp
  • 3,145
  • 1
  • 20
  • 24
  • 3
    No, I don't need simply to format them to HTML, I need definitly split it to the list to work with it. – artem Nov 29 '11 at 21:08
8

Hm, I have partly solved this problem. I changed my filter to:

@register.filter(name='split')
def split(value, arg):
    return value.split('\n')

Why it didn't work with the original code?

artem
  • 16,382
  • 34
  • 113
  • 189
1

I wanted to split a list of words to get a word count, and it turns out there is a filter for that:

{{ value|wordcount }}

https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#wordcount

ryanjdillon
  • 17,658
  • 9
  • 85
  • 110
1

Apart from whether your original solution was the right approach, I guess the original code did not work because the meaning of the \n is not the same in Python code as it is in HTML: In Python code it means the escaped newline character, in HTML it is just the two separate characters \ and n. So passing as input parameter \n from the HTML template to the Python code is equivalent to splitting on the Python string \\n: a literal \ followed by a n.

Tim van der Leeuw
  • 337
  • 2
  • 7
  • actually, this is the answer that really answers the question (why is the OPs templatefilter not working?)! though, there is no solution to the problem. – benzkji Aug 19 '20 at 18:15