NSView remove some subviews from superview

Question

I have a ad layout program which builds pages (NSView class Page) and on each page places margins and gutters (more NSViews) and then ads (NSView class Ad). The app auto places ads from a database source, looking for the proper space to fill on each page. The user then has the option to move the ads from say page 4 to page 2. They also have the option to manually flow the ads or have the app autoflow, the assumption being that the ad you just moved will end up in the 0/0 x/y location and then the others will flow to any available space, being pushed to the next page if there is no space on the current one (due to the ad you just moved).

What I was doing was getting all the pages (themselves subviews of an NSView called masterpage) and then looping through them to get all of their subviews into an array. Loop through that array, filtering for margins and gutters and if it is an ad remove it from the superview. My thought was to start with a clean page and replace all the ads. Problem is I keep getting this error:

Collection <NSCFArray: 0x1078900> was mutated while being enumerated.

I'm using this code:

//loop through all the pages
    for(NSView* thisPage in masterPageSubViews) { 

        //get all the ads on this page
        NSArray* thisPageSubviews = [thisPage subviews];
        for(NSView* thisPageSubview in thisPageSubviews) { 
            if ([[thisPageSubview className] isEqual:@"Ad"]) { 
                [thisPageSubview removeFromSuperview];
            }
        }
    }

I guess I am confused as to why I am getting this error. I thought the objects in the array were separate from the objects being created in the loop.

Since the number of ads on each page is dynamic how can I strip them from their superview without utilizing an array?

jrturton · Accepted Answer · 2011-11-01T16:45:31.257

7

As the error says, you can't amend the contents of an array while going through it using fast enumeration. removeFromSuperview removes the view from its superview's subviews array (that is a hard sentence to read!). This means you are mutating the array while you are enumerating it.

There is probably a better way, but you could have an NSMutableArray which you populate with the Ad views, then once you've finished, you can make them remove themselves from the superview (untested code, type in browser!)

NSMutableArray *viewsToRemove = [[NSMutableArray alloc] init];
for(NSView* thisPage in masterPageSubViews) 
{           
    //get all the ads on this page         
    NSArray* thisPageSubviews = [thisPage subviews];         
    for(NSView* thisPageSubview in thisPageSubviews)              
        if ([thisPageSubview isMemberOfClass:[Ad class]]) 
            [viewsToRemove addObject:thisPageSubview];                                 
}         
[viewsToRemove makeObjectsPerformSelector:@selector(removeFromSuperview)];
[viewsToRemove release];

edited Nov 01 '11 at 16:45

answered Nov 01 '11 at 16:09

jrturton

118,105
32
252
268

Thanks for the quick reply, I'm going to give that a try. But I am still confused as to how I am amending the contents of the array. Is it because as I loop through the array I am removing the view from its superview and thus the object that the array object is pointing to is no longer there? – PruitIgoe Nov 01 '11 at 16:30
Also thanks for the isMemberOfClass method. Didn't know that one. – PruitIgoe Nov 01 '11 at 16:31
Added an explanatory line in the answer regarding mutating the array while you are enumerating it. – jrturton Nov 01 '11 at 16:36
it worked, just needed to fix the first NSMutableArray call, there was no *, other than that it was fine. – PruitIgoe Nov 01 '11 at 16:37
ah, the explanation makes sense. Thanks. – PruitIgoe Nov 01 '11 at 16:38

score 6 · Answer 2 · answered Sep 24 '12 at 19:10

The above answer is rather expensive, why create objects when you can avoid it? And you can do the same thing with less code.

while([[superView subviews] count] > 0) {
    [[[superView subviews] objectAtIndex:0] removeFromSuperview];
}

EDIT: I'm new to Objective C and Cocoa, so I have no idea if this will works without ARC, as I've never been coding without it.

Dipak Narigara · Answer 3 · 2014-01-04T12:33:51.910

0

if([[yourView subviews] count] > 0) {
    [[[yourView subviews] objectAtIndex:0] removeFromSuperview];
}

Good Luck !!!

edited Jan 04 '14 at 12:33

answered Jan 04 '14 at 11:20

Dipak Narigara

1,796
16
18

score 0 · Answer 4 · answered Nov 11 '14 at 04:48

At least since 10.10 you can use fast enumeration on subviews since it returns a copy.

[view.subviews enumerateObjectsUsingBlock:^(NSView * subview, NSUInteger idx, BOOL *stop) {
    [subview removeFromSuperview];
}];

score 0 · Answer 5 · answered Feb 19 '15 at 03:35

If checking the class is an issue (and in the original question it was), then, again without an enumerator, the problem can be solved from the back-end:

NSArray *subs = [myView subviews];
for(NSInteger i=[subs count]-1; i>0; i--){
    if([[subs[i] className]isEqual:@"nameOfClassToDelete"]){
        [subs[i] removeFromSuperviewWithoutNeedingDisplay];
    }
}

I have this code in practice, it works :-)

NSView remove some subviews from superview

5 Answers5