Call base method at beginning or end of method?

Question

The only similar question to this I found was this and the answer suggested having to use Reflector to find out.

What about in just the majority of the cases? Generally, is the base method called first or last in a method?

I noticed in some libraries it is called at the beginning at the method and in the XNA Framework they're called at the end of methods (base.Update, base.Draw, et cetera).

H H · Accepted Answer · 2020-02-26T06:37:47.553

34

It depends on whether you want you derived behaviour to happen before or after the base behaviour.

And don't forget you can call the base method in the middle or not at all.

Having said that, in general it will be called as the first thing. Because then your overriding method has the option to 'overwrite' settings done by the base-class.

But in methods like Close or Dispose it is more customary (sometimes mandatory) to call it in the end.

edited Feb 26 '20 at 06:37

answered Oct 17 '11 at 19:07

H H

263,252
30
330
514

12

Usually creation scenarios have them at the beginning. Cleanups at the end. Somthing like update might have it in the middle. – George Mamaladze Oct 17 '11 at 19:09
1

@GeorgeMamaladze How about events? Any rule of thumb there? e.g. `protected override void OnResize(...)` – Bitterblue Mar 12 '20 at 08:10

score 11 · Answer 2 · answered Oct 17 '11 at 19:08

It entirely depends on what you want to do. There's not really a "general" rule about what should happen. For example, you might want to do some extra validation, then call the base method, then do something else. Or maybe you just want to time how long the base method takes to call.

Treat each case as an individual situation.

Call base method at beginning or end of method?

2 Answers2