foreach array_combine two array by php

Question

There are two arrays that One is the correct answers and the other is the user's answer.

My Php:

$i=1;
$correct = array('a','d','c','a','b','c');
$user    = array('a','c','c','a','c','c');

foreach (array_combine($correct, $user) as $co => $ur) {
    if($co == $ur) {
        echo $i.':true <br>';
    } else {
        echo $i.':false <br>';
    }
    $i++;
}
echo 'True: '.count($co == $ur);
echo 'False: '.count($co == $ur);

out:

1:true
2:false
3:true
4:false
Error: count(): Argument must be of type Countable...

Number 4 is wrong (It must be true). It does not show numbers 5 and 6 in the output. It also does not show the true and false numbers. I want to show the true and false result in the output.

My Out:

1: true
2: false
3: true
4: true
5: false
6: true

True: 4
False: 2

I wouldn't expect `count($co == $ur)` to return anything since the scope of those variables are within the for each loop. Also, array_combine takes one array for the keys and another for the values. However, if you have duplicate keys they won't be added seperately. — imvain2, Aug 23 '23 at 17:50

score 0 · Accepted Answer · answered Aug 23 '23 at 17:56

Array_Combine takes one array for the keys and one for the values. Duplicate keys won't be created and you have duplicate keys.

Another solution is to loop through one array and compare it that way:

$correct = array('a','d','c','a','b','c');
$user    = array('a','c','c','a','c','c');

$totals = ["correct" => 0,"incorrect" => 0];

foreach($correct as $i => $answer){
    if($user[$i] == $answer){
        $totals["correct"] ++;
        echo "$i correct<br>";
    }
    else{
        $totals["incorrect"] ++;
        echo "$i incorrect<br>";
    }   
}

echo $totals["incorrect"] . " - incorrect<br>";
echo $totals["correct"] . " - correct<br>";

score 0 · Answer 2 · answered Aug 23 '23 at 18:17

Here's a corrected version:

$correct = array('a', 'd', 'c', 'a', 'b', 'c');
$user = array('a', 'c', 'c', 'a', 'c', 'c');

$trueCount = 0;
$falseCount = 0;

for ($i = 0; $i < count($correct); $i++) {
    if ($correct[$i] == $user[$i]) {
        echo ($i + 1) . ': true <br>';
        $trueCount++;
    } else {
        echo ($i + 1) . ': false <br>';
        $falseCount++;
    }
}

echo 'True: ' . $trueCount . '<br>';
echo 'False: ' . $falseCount;

This should give you the desired output:

1: true
2: false
3: true
4: true
5: false
6: true
True: 4
False: 2

lukas.j · Answer 3 · 2023-08-23T18:26:13.323

$correct = [ 'a', 'd', 'c', 'a', 'b', 'c' ];
$user = [ 'a', 'c', 'c', 'a', 'c', 'c' ];

$result = array_count_values(
  array_map(
    static fn(string $c, string $u): int => (int)( $c === $u ),
    // or without type hints:
    // static fn($c, $u) => (int)( $c === $u ),
    $correct,
    $user
  )
);

echo $result[true];    // Output: 4
echo $result[false];   // Output: 2

The int cast is needed because array_count_values does not support counting booleans, only ints and strings.

If only the count for 'true' values is needed, this will do:

$result = array_sum(
  array_map(
    static fn(string $c, string $u): bool => $c === $u,
    // or without type hints:
    // static fn($c, $u) => $c === $u,
    $correct,
    $user
  )
);

echo $result;   // Output: 4

foreach array_combine two array by php

3 Answers3