PHP recursive file& folder delete function: 'Directory not empty' error message

Question

I'm trying to create function which removes all file and directories on webhosting excluding given files and folders arrays

function cleanUp($exdirs, $exfiles){
$it = new RecursiveIteratorIterator(
  new RecursiveDirectoryIterator('.'), 
  RecursiveIteratorIterator::CHILD_FIRST
);
foreach($it as $entry) {
  if ($entry->isDir() && !in_array($entry->getBasename(), $exdirs)) {
    rmdir($entry->getPathname());
  }
  else {
    if (!in_array($entry->getFileName(), $exfiles)) {
      unlink($entry->getPathname());
    }
    else {
      $exdirs[] = dirname($entry->getFileName());
    }
  }
}
}

And calling this function like this

$excludeDirsNames = array('cgi-bin');
$excludeFileNames = array('.htaccess', 'ws.zip', 'update.php');
cleanUp($excludeDirsNames , $excludeFileNames);

Now the problem is, it deletes but getting error message: Directory not empty on line rmdir($entry->getPathname()); several times. How to fix that problem?

Is this not here: http://stackoverflow.com/questions/7685134/php-recursive-delete-function. As you are experiencing an issue with the previous answer, I would sugest you go back to that thread, deselect the answer you approved and ask questions there. If the answer you chose does not work, you should revert your choice so as to not confuse future users how look at the thread. — SW4, Oct 07 '11 at 09:49

KingCrunch · Accepted Answer · 2011-10-07T10:09:36.507

1

You allow to exclude files and directories, but you don't test, if a directory contains other files, or directories, that were excluded before.

if (substr($oneExcludedFileOrDirectory, 0, strlen($currentDir) === $currentDir) {
  echo "Directory not empty";
}

Just a simple prefix comparison: Is "dir" is prefix of one of the excluded paths? Only works for absolute paths (and some other minor things), but it should explain, whats the matter.

edited Oct 07 '11 at 10:09

answered Oct 07 '11 at 09:49

KingCrunch

128,817
21
151
173

don't get it. how will look like your theory in my function – heron Oct 07 '11 at 09:54
When `/path/to/my/file` starts with `/path/to`, then `/path/to/my/file` is _in_ `/path/to/` and when you don't delete `/path/to/my/file`, then `/path/to` is not empty. – KingCrunch Oct 07 '11 at 09:55
Better? Now you should be able to integrate it into your code yourself. – KingCrunch Oct 07 '11 at 10:10
it needs to be within foreach loop? – heron Oct 07 '11 at 10:10
i really can't integrate it to my code. Please show me where it must be – heron Oct 07 '11 at 10:15
Take a look at this scrshot http://prntscr.com/3dbn0 In common folder located .htaccess file. it can't delete .htaccess – heron Oct 07 '11 at 10:37

score 0 · Answer 2 · answered Oct 07 '11 at 09:56

Here are two reasons why it not work:

1) In one of your child-folder are files you are excluding. There are not deleted, so it is not possible to "rm" the folder.

2) After the "unlink" and "rmdir"-Funktion call "clearstatcache();". I think this will solve your problem. The files are delete, but the information is still available in the cache.

PHP recursive file& folder delete function: 'Directory not empty' error message

2 Answers2