0

scr of my PR

Hello. I did PR from terminal to github as always but the file is so big that I cannot scroll down to get the final commit and pull request button. What do I do in this situation?

Is it normal that node_modules is so big or I have just installed some bad things?

phd
  • 82,685
  • 13
  • 120
  • 165
Chumba
  • 1
  • 1
  • 1
    I might be wrong but I don't think that node_modules should be added/committed _ever_ given that it's stuff that is downloaded from dependencies. – eftshift0 Jan 30 '23 at 11:49
  • I am new to this. So can i delete node_modules after I used webpack? – Chumba Jan 30 '23 at 11:50
  • 4
    Usually you have /node_modules in your .gitignore so it does not show up in your diff. – Basti Jan 30 '23 at 11:51
  • When committing, no need to add the `node_modules` directory to GitHub. Create a new file called `.gitignore` and add the `node_modules/` in that. You will notice a difference. – sumanth Jan 30 '23 at 12:22
  • https://stackoverflow.com/search?q=%5Bgit%5D+ignore+node_modules – phd Jan 30 '23 at 12:25
  • As said before, 'nodes_modules' should not be tracked so maybe repo owner need to ignore **and untrack it** before you will do your PR. Maybe you should open an issue to ask for that if it's the case. If the repo is public, could you share the url so it could be checked? – Philippe Jan 30 '23 at 13:19

0 Answers0