Suspicious indentation: This is indented but is not continuing the previous expression

Question

Android studio showing me this issue with red line below my code line

"Suspicious indentation: This is indented but is not continuing the previous expression (binding.cllInternetA...) (Previous statement here)"

override fun onResume() {
    super.onResume()
    //Clear search edit text
    binding.etSearch.text?.clear()

    lookUpNumberVM.isInternetLiveData.observe(viewLifecycleOwner) {
        if (it) {
            binding.cllMain.visibility = View.VISIBLE
            binding.cllInternetAvailability.visibility = View.GONE
        } else {
            binding.cllMain.visibility = View.GONE
            binding.cllInternetAvailability.visibility = View.VISIBLE
              makeSnackBar(binding.root,"No internet connection")
        }
    }
}

my code is above and you can see issue in screenshot attachecd with question. I will really appreciate your efforts.

The line of makeSnackBar is indented with two spaces for no reason. Try to delete these two spaces. — hata, Dec 07 '22 at 09:21

score 35 · Answer 1 · answered Dec 31 '22 at 09:57

35

Simply Use

ctrl+Alt+L

All will be fine Cheers :)

answered Dec 31 '22 at 09:57

Jadu

489
3
10

1

Reformat Code? You should explain... – The incredible Jan Jan 06 '23 at 08:01
Yup Android Studio just reformats the code and aligns it perfectly – Jadu Jan 15 '23 at 11:50
Thanks for tip, typical that it would require an three special key fix. All those bright red error lines where irritating. – Androidcoder Mar 31 '23 at 16:18
wow it was magic <3 – Maruf Alam Aug 09 '23 at 10:24

Krokomot · Answer 2 · 2022-12-07T11:41:01.840

As hata pointed out in his commentary, it's probably the additional intendation (+2 spaces) of the makeSnackBar line. Note, that you can avoid such problems in a general way by ending your code statements with a semicolon, which is usually recommended. This also improves readability. So:

override fun onResume() {
    super.onResume();
    //Clear search edit text
    binding.etSearch.text?.clear();

    lookUpNumberVM.isInternetLiveData.observe(viewLifecycleOwner) {
        if (it) {
            binding.cllMain.visibility = View.VISIBLE;
            binding.cllInternetAvailability.visibility = View.GONE;
        } else {
            binding.cllMain.visibility = View.GONE;
            binding.cllInternetAvailability.visibility = View.VISIBLE;
            makeSnackBar(binding.root,"No internet connection");
        }
    }
}

Thereby intendation wouldn't play a role anymore (except for readability of course, so keep using intendations) as the compiler has now unambigious information about where a code statement begins and ends.

A semicolon a the end of a line doesn't improve anything. "The general rule in Kotlin is not to use semicolons." https://kotlincompact.com/no-semicolon.html — The incredible Jan, Jan 06 '23 at 08:07
I admit, that even the official https://kotlinlang.org/docs/coding-conventions.html#semicolons recommends "Omit semicolons whenever possible." However neither here nor in your link it is elucidated why that should be in any way better or at least helpful. On the other side there are good reasons to use semicolons -- readabilty and less error susceptibility. — Krokomot, Jan 06 '23 at 21:51

score 1 · Answer 3 · edited May 31 '23 at 16:15

Help::5

Android studio showing me this issue with red line below my code line

"Suspicious indentation: This is indented but is not continuing the previous expression

adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
spinner2.setAdapter(adapter);

spinner2.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener() {
            @Override
            public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {
            end=parent.getItemAtPosition(position).toString();
                them.set(1,end);
                printDiametroPdf(them);
                if (position == 0) {

Suspicious indentation: This is indented but is not continuing the previous expression

3 Answers3