using a string resource in a Toast

Question

My code is:

public static void ToastMemoryShort (Context context) {
    CharSequence text = getString(R.string.toast_memoryshort); //error here
    Toast.makeText(context, text, Toast.LENGTH_LONG).show();
    return;
    }

but I'm getting "Cannot make a static reference to the non-static method getString(int) from the type Context" in Eclipse. I'm trying to get ready for localising my app (getting all the hard coded strings into resources), so where I have:

getString(R.string.toast_memoryshort)

I previously had a hard coded string which was fine.

I'm not sure what's going on here (Java noob). Can anyone enlighten me please?

Many thanks

Baz

Rasel · Answer 1 · 2012-07-18T12:02:34.490

28

Change to

 public static void ToastMemoryShort (Context context) {

        Toast.makeText(context, context.getString(R.string.toast_memoryshort), Toast.LENGTH_LONG).show();
        return;
        }

edited Jul 18 '12 at 12:02

answered Sep 07 '11 at 09:46

Rasel

15,499
6
40
50

The reason this answer is so much popular is that using `getString` in the first place suggests that string itself was needed for some reason (var injection, formatting etc.). Plus, it actually resolves the exception in question which is a genuine value. – tishma May 15 '17 at 09:11

score 6 · Accepted Answer · answered Sep 07 '11 at 09:48

6

Just use this instead:

makeText(Context context, int resId, int duration) Make a standard toast that just contains a text view with the text from a resource.

From http://developer.android.com/reference/android/widget/Toast.html

answered Sep 07 '11 at 09:48

Stefan H Singer

5,469
2
25
26

Actually, it was a combination of your answer and Rasel's: Needed the .show on the end, didn't need Rasel's ""+ before the resource ID: Toast.makeText(context, R.string.toast_memoryshort, Toast.LENGTH_LONG).show(); so +1 to Rasel too. Many thanks. – Barry Sep 07 '11 at 13:01

score 2 · Answer 3 · edited Jun 30 '18 at 12:02

You could make your toast more generic like this:

public void toast(String msg){
    Context context = getApplicationContext();
    CharSequence text = msg;
    int duration = Toast.LENGTH_SHORT;

    Toast toast = Toast.makeText(context, text, duration);
    toast.show();
}

Then just call when you need like this:

toast( "My message hardcoded" );

or by referring to strings.xml like this:

toast( this.getString(R.string.toast_memoryshort) );

score 2 · Answer 4 · answered Jul 11 '19 at 09:56

2

Use the below code to get the desired output:

Toast.makeText(getApplicationContext(),getString(R.string.exit_survey_toast),Toast.LENGTH_LONG).show();

replace exit_survey_toast with your string value.

answered Jul 11 '19 at 09:56

Prajwal Waingankar

2,534
2
13
20

score 0 · Answer 5 · answered Jun 10 '16 at 14:45

0

You should change

CharSequence text = getString(R.string.toast_memoryshort); //error here

for:

CharSequence text = context.getString(R.string.toast_memoryshort);

The getString function is implemented in Context#getString(int)

answered Jun 10 '16 at 14:45

JoseF

1,261
13
30

using a string resource in a Toast

5 Answers5

Linked

Related