Array repeated elements

Question

I am trying to ask a user to input elements, but if the user inputs a repeated element my method should return false. So far this is what I have... Thank you in advance!

public boolean setGuess(int index, int value) // required by instructor
{ 
    int [] guesses = new int[countVal]; //countVal is array length
    for (int i = 0; i < guesses.length; i++)
        for (int j = 0; j < i; j++)
        {
            if (guesses[i] == guesses[j])
                return false;
        }
    return true;
}

So what is your question ? Is not compiling ? not giving you output what you want ? — Swagatika, Sep 06 '11 at 05:00
Also worth mentioning is that you have a memory leak with allocating the guesses and never delete[]'ing it. — Corbin, Sep 06 '11 at 05:02
A general rule: The more specific the question, the more helpful the answer. — Hovercraft Full Of Eels, Sep 06 '11 at 05:02
@Corbin: That is plain wrong. The memory is released when flow of control returns from the method. — blubb, Sep 06 '11 at 19:47
Oh my! I can't believe I did that! I'm glad someone caught that. I should have read the tags or realized that it's java from the boolean return type. Hope I didn't confuse anyone! — Corbin, Sep 06 '11 at 19:51

score 2 · Answer 1 · answered Sep 06 '11 at 05:04

2

boolean hasRepeatedElement = new HashSet(Arrays.asList(arr)).size() == arr.length;

answered Sep 06 '11 at 05:04

Mike Samuel

118,113
30
216
245

score 0 · Answer 2 · answered Sep 06 '11 at 05:08

Although you did not ask a real question, it is fairly obvious you are going to get into trouble because you allocated an array of integers but never filled them with anything. Then you starting looking for duplicates.

If your question was "this doesn't work for me" then this is one place to look.

Another is that you have a method called setGuess which does not at all sound like a method that should look for duplicates. The fact that it is called setGuess and is "required by instructor" means there is much more to this assignment than you have in your question.

Consider expanding the question, then I can withdraw this answer, which was too long for a comment....

score 0 · Answer 3 · answered Sep 06 '11 at 05:12

More over in the same Question 1. in place of guesses.length u can use countVal.
2. Whats the use of "int index, int value" parameters, you are not using in the method. 3. declaring guesses[] will will have only 0 at all the indexes, so "guesses [i] == guesses[j]" has no meaning.

Try to answer all the above points, will help you code better.

Array repeated elements

3 Answers3