Only detects the first element of the array when it's compared with the input. I've tried with a lot of things and it's doesn't work out

Question

It was supposed to be a function that detects when it's a vowel. But, it didn't work out as expected

#include <stdio.h>
#include <conio.h>

// It didn't work out. It failed

// It was supposed to be a function that detects when it's a vowel.
// But, it didn't work out as expected

int isVowel(char c) {
    char letters[] = {'A', 'I', 'U', 'E', 'O', 'a', 'i', 'u', 'e', 'o'};
    for (int i = 0; i <= 9; i++) /* It detects A, but nothing else*/ {
        if (letters[i] == c)
            return printf("A vowel\n");
        else 
            return printf("Not a vowel \n");
    }

}

int main() {
    char c;
    printf("Press a key: ");
    do {
        c = getch();
        char ans = isVowel(c);
    } while(c != 13);
}

Any way I can fix it up to compare the whole array?

What do you expect `return printf("A vowel\n");` to do? Have you read about what `printf` returns? — Ted Lyngmo, May 22 '22 at 20:04

score 0 · Accepted Answer · answered May 22 '22 at 22:31

You are returning after you check for 'A' regardless of whether it matches. You want to check all the possible vowels until you match or hit the end of the list. I also would make the function void since you ignore the return code.

void isVowel(char c) {
    char letters[] = {'A', 'I', 'U', 'E', 'O', 'a', 'i', 'u', 'e', 'o'};
    for (int i = 0; i <= 9; i++) /* It detects A, but nothing else*/ {
        if (letters[i] == c)
            printf("A vowel\n");
            return;
    }

    printf("Not a vowel \n");
 }

}

Only detects the first element of the array when it's compared with the input. I've tried with a lot of things and it's doesn't work out

1 Answers1