Rails validate only on user create or update

Question

I have a validates_confirmation_of :password in my User model. The problem is I also run @comment.user.save! when a comment is created to update some attributes on the user account.

I get an error when creating a comment Validation failed: Password confirmation can't be blank. I can't add :on => "save" to my validation because my comments controller is also calling the save function.

I've read this thread Rails model validation on create and update only, but it doesn't answer my specific issue.

UPDATE User model snippet:

class User < ActiveRecord::Base

  attr_accessor :password

  # validations
  validates_presence_of :username
  validates_length_of :username, :within => 6..25
  validates_uniqueness_of :username
  validates_presence_of :email
  validates_length_of :email, :maximum => 100
  validates_format_of :email, :with => EMAIL_REGEX
  validates_confirmation_of :password, :if => :password_changed?
  validates_presence_of :password_confirmation
  validates_length_of :password, :within => 4..25, :on => :create

  before_save :create_hashed_password
  after_save :clear_password

  private

  def clear_password
    self.password = nil
  end

end

Mario Uher · Answer 1 · 2011-08-29T11:32:34.777

6

Why exactly do you run @comment.user.save!? Touching (e.g. updating timestamps) and increasing comments count can be done via built-in mechanisms.

Edit: I'd suggest something similar to:

class Comment < ActiveRecord::Base
  after_save :rank_user

  def rank_user
    # calculate rank
    user.update_attribute(:rank, rank)
  end
end

Benefits of this approach:

Your controller and models will be clean and rank_user will be called automatically, without an explicit call of @comment.user.save!.
According to the update_attribute documentation, validations will be skipped which then results in no password-confirmation errors.

edited Aug 29 '11 at 11:32

answered Aug 29 '11 at 11:17

Mario Uher

12,249
4
42
68

I am running that because I am updating a user.rank attribute. Can I do something like that outside of my comments controller? – Tony Beninate Aug 29 '11 at 11:20

score 6 · Accepted Answer · edited Mar 18 '15 at 14:40

6

According to this validates_confirmation_of the model should be valid if the password_confirmation field is nil. Are you storing it to DDBB? Or maybe something is wrong with your validation, could you paste your user model here?

Either way you can try something like this:

validates_presence_of :password_confirmation, if: -> { password.present? }
validates_confirmation_of :password, if: -> { password.present? }

edited Mar 18 '15 at 14:40

Fabian de Pabian

599
4
20

answered Aug 29 '11 at 11:56

cicloon

1,099
5
13

Perhaps the reason it's failing is because I have a `validates_presence_of :password_confirmation`? I added that, because it doesn't check it if the user leaves it blank. Also, it's saying `:password_changed?` is undefined. Do I need to define that? – Tony Beninate Aug 29 '11 at 12:36
Since password is a virtual field, the method password_changed? is not generated. I edited my answer to correct this, it should work. – cicloon Aug 29 '11 at 14:19
Thanks a bunch. This is exactly what I was missing. – Tony Beninate Aug 29 '11 at 22:20

Rails validate only on user create or update

2 Answers2