Will it be simpler to convert this code from CStringArray to std::vector?

Question

Given this code:

void CSelectNamesDlg::ShuffleArray(CString strName, CStringArray *pAryStrNames)
{
    if (pAryStrNames == nullptr)
        return;

    const auto iSize = pAryStrNames->GetSize();
    if (iSize > 1)
    {
        // First, we must locate strName in the array
        auto i = CSelectNamesDlg::LocateText(strName, pAryStrNames);
        if (i != -1)
        {
            const auto iName = i;

            // We must now shuffle the names from the bottom to the top
            const auto iCount = gsl::narrow<int>(iSize) - iName;
            for (i = 0; i < iCount; i++)
            {
                CString strTemp = pAryStrNames->GetAt(iSize-1);
                pAryStrNames->RemoveAt(iSize-1);
                pAryStrNames->InsertAt(0, strTemp);
            }
        }
    }
}

int CSelectNamesDlg::LocateText(CString strText, const CStringArray *pAryStrText)
{
    bool bFound = false;
    int i{};

    if (pAryStrText != nullptr)
    {
        const auto iSize = pAryStrText->GetSize();
        for (i = 0; i < iSize; i++)
        {
            if (pAryStrText->GetAt(i) == strText)
            {
                // Found him!
                bFound = true;
                break;
            }
        }
    }

    if (!bFound)
        i = -1;

    return (int)i;
}

If I convert my CStringArray into a std::vector<CString is it going to be simpler to achieve the same PerformShuffle and LocateText methods?

Should I just stay with CStringArray?

If you use something like this, you could keep CStringArray, and use it with the stl algorithms: https://github.com/mariusbancila/mfccollectionutilities — Mercury Dime, May 07 '22 at 09:04

score 2 · Accepted Answer · answered May 09 '22 at 18:54

2

I know of 1 (ONE!) benefit of MFC array over std::vector - they support MFC-style serialization. If you use it - you may be stuck.

However, if you don't - I would use std::vector<CString>. Your LocateText (that is overly verbose) will become obsolete - just use find

Also, your ShuffleArray is very inefficient (remove/insert one item at a time). Using a vector will allow you to do something like Best way to extract a subvector from a vector?

answered May 09 '22 at 18:54

Vlad Feinstein

10,960
1
12
27

1

Thanks. I do serialize `CStringArray` data, but not with respects to this particular info I have been discussing. The only caveat is that the source `CStringArray` is obtained via a call to a external DLL. So I would have to add a wrapper method to transform from the array into the vector. Thanks for the links. – Andrew Truckle May 09 '22 at 19:02

Will it be simpler to convert this code from CStringArray to std::vector?

1 Answers1