Calling a hedera smart contract function with a simple comparison operator fails with CONTRACT_REVERT_EXECUTED status

Question

Sorry for the newbie question. I am experimenting with hedera Smart Contracts. Whenever trying to call a simple function which compares the uint argument with a uint member of the contract I systematically get a CONTRACT_REVERT_EXECUTED status.

solidity

    function compare(uint number_) public view returns (bool){
        
        return (number_ > secret_number);
    }

java

    public static boolean compare(Client client, ContractId contractId, int guess) throws TimeoutException, PrecheckStatusException
    {
         // Calls a function of the smart contract
        ContractCallQuery contractQuery = new ContractCallQuery()
             //Set the gas for the query
             .setGas(100_000) 
             //Set the contract ID to return the request for
             .setContractId(contractId)
             //Set the function of the contract to call 
             .setFunction("compare", new ContractFunctionParameters().addUint32(guess))
             //Set the query payment for the node returning the request
             //This value must cover the cost of the request otherwise will fail 
             .setQueryPayment(new Hbar(4)); 

        //Submit to a Hedera network
        ContractFunctionResult getMessage = contractQuery.execute(client);

        
        return getMessage.getBool(0);
    }

Exception * Exception in thread "main" com.hedera.hashgraph.sdk.PrecheckStatusException: Hedera transaction 0.0.34318751@1651508840.487521537 failed pre-check with the status CONTRACT_REVERT_EXECUTED at com.hedera.hashgraph.sdk.Executable$GrpcRequest.mapStatusException(Executable.java:457) at com.hedera.hashgraph.sdk.Executable.execute(Executable.java:241) at com.hedera.hashgraph.sdk.Query.execute(Query.java:29) at com.hedera.hashgraph.sdk.Executable.execute(Executable.java:189) at com.hedera.hashgraph.sdk.Query.execute(Query.java:29) at hbarTexting.GuessNumberSmartContract.compare(GuessNumberSmartContract.java:132) at hbarTexting.GuessNumberSmartContract.main(GuessNumberSmartContract.java:257) *

What am I doing wrong here?

Any help greatly appreciated!

To clarify a bit I am really trying to understand the meaning of the status CONTRACT_REVERT_EXECUTED. The only information I found on hedera documentation is very concise https://docs.hedera.com/guides/docs/sdks/smart-contracts/errors CONTRACT_REVERT_EXECUTED = Contract REVERT OPCODE executed. I tried increasing gas argument as well as QueryPayment but in vain. The comparison operation is very simple so I do not understand why it would not succeed on hedera Network. — Aobara, May 02 '22 at 16:55

score 0 · Answer 1 · answered May 02 '22 at 18:57

According to the sdk's unit tests, there are three cases where the opcode is thrown:

Cannot execute contract when contract function parameters are not set
Test: ContractExecuteIntegrationTest
Cannot call contract function when contract function is not set
Test: ContractCallIntegrationTest
Cannot create contract when constructor parameters are not set
Test: ContractCreateIntegrationTest

Gr Kim :-)

score 0 · Accepted Answer · answered May 25 '22 at 12:21

I finally got it to work after properly setting contract function parameters

    public static String tryNumberGuess(Client client, ContractId contractId, int guess) throws TimeoutException, PrecheckStatusException
{
     // Calls a function of the smart contract
    ContractCallQuery contractQuery = new ContractCallQuery()
         //Set the gas for the query
         .setGas(1000_000) 
         //Set the contract ID to return the request for
         .setContractId(contractId)
         //Set the function of the contract to call 
         .setFunction("guess", new ContractFunctionParameters().addUint256(new BigInteger(""+guess)))
         //Set the query payment for the node returning the request
         //This value must cover the cost of the request otherwise will fail 
         .setQueryPayment(new Hbar(4)); 

    //Submit to a Hedera network
    ContractFunctionResult getMessage = contractQuery.execute(client);

    
    return getMessage.getString(0);
}

Turns out function parameter required type Uint256, after compilation with solidity version 0.7.0. In other words Uint32 did not work, but that was not only clear after compilation and testing within remix. Not clear from the initial solidity source code...

score 0 · Answer 3 · answered Dec 23 '22 at 16:26

0

Hedera will fail Hedera is a distributed public network designed to provide a secure, decentralized, and open platform for businesses and developers to create and operate applications. It is not designed to fail, but it is possible for the network or applications built on it to experience a variety of issues, such as network slowdowns, security vulnerabilities, or scalability issues

answered Dec 23 '22 at 16:26

Syedur Rahman

1

As it’s currently written, your answer is unclear. Please [edit] to add additional details that will help others understand how this addresses the question asked. You can find more information on how to write good answers [in the help center](/help/how-to-answer). – Community Dec 26 '22 at 07:43

Calling a hedera smart contract function with a simple comparison operator fails with CONTRACT_REVERT_EXECUTED status

3 Answers3