Default element value is used instead of user defined in C?

Question

I am beginner in C. I have been writing a program code to find largest element in Array. Passed Value is not able to store in array of type: float. Instead default Value:0 is being stored. What to do?

#include <stdio.h>

// Largest Element

int main() {
    int n,i;
    float arr[100];

    printf("Enter Element Count in range(1,100):-");
    scanf("%d",&n);

    while(n>100 || n<1){
        printf("Enter Element Count in range(1,100) again:-");
        scanf("%d",&n);
    }

    for(i=0; i<n;i++){
        printf("Enter Element:-");
        scanf("%f",&arr[i]);
    }

    for(int k=0;k<n;k++){
        printf("Element-%d:-%d\n",k+1,arr[k]);
    }

    for(int j=0;j<n;j++){
        
        for(int k=j+1;k<n;k++){
            
            if (arr[j] < arr[k]){
                break;
            }
            else{
                printf("Largest Element:-%d\n",arr[j]);
                break;
            }
        }
        continue;   
    }

    return 0;
}

OUTPUT SCREEN

You need to use `%f` when printing the array value, not `%d`. — Barmar, Apr 26 '22 at 20:31
Thanks for reply. One More Doubt Occurred, Still I am not able to have desired output. Largest Element is still not printing. Where I am going wrong for it? My Line of Thinking:- I am comparing first element to rest. If it is largest then print it. If not then comparison of next to rest all. — RACHIT MITTAL, Apr 26 '22 at 20:40
@RACHITMITTAL the logic of your code is not 100% correct for what your initial goal is. — ioannis-kokkalis, Apr 26 '22 at 20:43
after the printing issues are fixed, your algorithm to find the max [isn't working](https://godbolt.org/z/71afz56nx) I'm afraid. No need for the double `for` loop, just do something like `float max = arr[0]; for(j=1; j max) max = arr[j];` — yano, Apr 26 '22 at 20:44
Please always copy&paste the output as formatted text directly into the question instead of showing screenshots of plain text. — Gerhardh, Apr 26 '22 at 21:19
RACHIT MITTAL, Good compilers with warnings fully enabled will warn about `scanf("%f",&arr[i]);`. Save time, enable all warnings. — chux - Reinstate Monica, Apr 26 '22 at 22:19

score 3 · Answer 1 · edited Apr 26 '22 at 20:39

3

Explanation In the two cases below you are using %d to print a float number. That's why you are getting 0 printed and not the actual number.

Use %f like you did for reading the value on scanf earlier instead of %d for the float values.

printf("Element-%d:-%d\n",k+1,arr[k]);

printf("Largest Element:-%d\n",arr[j]);

edited Apr 26 '22 at 20:39

Lee Taylor

7,761
16
33
49

answered Apr 26 '22 at 20:36

ioannis-kokkalis

432
1
3
13

Thanks for Doubt Clearance, Sir. – RACHIT MITTAL Apr 26 '22 at 20:44

Vlad from Moscow · Accepted Answer · 2022-04-26T20:54:04.863

To output values of the type float you have to use the conversion specifier f. The conversion specifier d is designed to output integer values.

So these calls of printf

printf("Element-%d:-%d\n",k+1,arr[k]);

and

printf("Largest Element:-%d\n",arr[j]);

are incorrect. You have to write

printf("Element-%d:-%f\n",k+1,arr[k]);

and

printf("Largest Element:-%f\n",arr[j]);

Also if you are going to find the largest element in the array then these for loops do not make a sense.

for(int j=0;j<n;j++){
    
    for(int k=j+1;k<n;k++){
        
        if (arr[j] < arr[k]){
            break;
        }
        else{
            printf("Largest Element:-%d\n",arr[j]);
            break;
        }
    }
    continue;   
}

At least for example the continue statement is redundant. And the inner for loop is also redundant because it is interrupted at once due to break statements in the if-else statement.

The largest element is searched the following way using only one for loop.

int largest = 0;

for ( int i = 1; i < n; i++ )
{
    if ( arr[largest] < arr[i] ) largest = i;
}

printf( "Largest Element:-%f at position %d\n",arr[largest], largest );

@stark Your advice does not make a sense. – Vlad from Moscow Apr 26 '22 at 21:42 — Vlad from Moscow, Apr 26 '22 at 21:42

Default element value is used instead of user defined in C?

2 Answers2