PHP preg_replace backreference causing undefined constant notice

Question

I'm trying to use NameCase a php class on code.google.com. When I run it I get this notice and I don't understand why.

PHP Notice: Use of undefined constant Mc - assumed 'Mc' in namecase.php(54) : regexp code on line 1

53   if( preg_match('/\bMac[A-Za-z]{2,}[^aciozj]\b/', $str) || preg_match('/\bMc/', $str) ) {
54     $str = preg_replace("/\b(Ma?c)([A-Za-z]+)/e", "$1.ucfirst('\\2')", $str);
55     // Now correct for "Mac" exceptions
56     $str = preg_replace('/\bMacEvicius/','Macevicius', $str); // Lithuanian
57     $str = preg_replace('/\bMacHado/',   'Machado', $str);    // Portuguese
58     $str = preg_replace('/\bMacHar/',    'Machar', $str);
59     ...

Is there anything that can be done to correct the code so it doesn't produce the notice.

Thanks

score 7 · Accepted Answer · answered Aug 18 '11 at 00:34

7

You need to quote the $1 in your replacement, e.g. "'$1'.ucfirst('\\2')" or better yet, use preg_replace_callback. In PHP 5.3+ you can pass it a closure, e.g:

$str = preg_replace_callback(
    "/\b(Ma?c)([A-Za-z]+)/",
    function($m) { return $m[1] . ucfirst($m[2]); },
    $str
);

answered Aug 18 '11 at 00:34

Long Ears

4,886
1
21
16

And before 5.3 you could already pass a closure with `create_function()`. Not as neat and 'clean' as 5.3+ closures perhaps, but still. – Decent Dabbler Aug 18 '11 at 00:46
Tested both solutions and worked perfect! Thanks for the quick reply. – Brandon Aug 18 '11 at 00:47
Correction: I meant anonymous function of course, not a closure. – Decent Dabbler Aug 18 '11 at 00:55

PHP preg_replace backreference causing undefined constant notice

1 Answers1