Worker thread termination in MFC

Question

What is the correct way to terminate a worker thread if it is taking too long to complete? I've read several articles claming that TerminateThread should be used with extreme caution, but I can't find any viable alternative.

Psudo code:

void CMyDialog::RunThread()
{
    CWinThread* pThread;            // pointer to thread
    DWORD dwWaitResult;             // result of waiting for thread


    // start thread
    pThread = AfxBeginThread(beginThread, this, 
                           THREAD_PRIORITY_NORMAL, 
                           0,     
                           CREATE_SUSPENDED);
    pThread->m_bAutoDelete = FALSE;
    pThread->ResumeThread();

    // wait for thread to return
    dwWaitResult = ::WaitForSingleObject(pThread->m_hThread, (30 * 1000)); 

    switch (dwWaitResult) 
    {
        case WAIT_OBJECT_0: 

            delete pThread;

            // success, continue

            break;

        case WAIT_TIMEOUT: 

            // thread taking too long, terminate it
            TerminateThread(pThread->m_hThread, 0);
            delete pThread;

            break;

    } // end switch on wait result


} 


UINT CMyDialog::beginThread(LPVOID pParam)
{
    // convert parameter back to dialog object and call method
    CMyDialog* dlg = (CMyDialog*) pParam;
    dlg->readDuration();

    return 0;
} // end beginThread


void CMyDialog::readDuration()
{
    // call a dll function that may take longer than we are prepared to wait, 
    // or even hang

} // end readDuration

Is this acceptable? All comments and suggestions gratefully recieved.

I am using MFC/C++ in Visual Studio 2008. Developing on Vista, targeting XP, Vista and 7.

score 1 · Answer 1 · edited May 23 '17 at 11:50

1

Its a bad idea to use TerminateThread its not safe and can cause some leaks. You can use events to tell your thread end. Some useful links

Good answer about terminatethread here

edited May 23 '17 at 11:50

Community

1
1

answered Aug 15 '11 at 15:17

Sanja Melnichuk

3,465
3
25
46

Thanks for the links, I'll work my way through them. I guess I should have said that it's difficult to terminate from within the thread itself as I'm calling a dll function that has been known to hang. I've edited my psuedo code to reflect that. – House Sparrow Aug 15 '11 at 15:43
@House Sparrow No problem, just ask :) – Sanja Melnichuk Aug 15 '11 at 15:46

score 1 · Accepted Answer · answered Aug 15 '11 at 18:13

1

Is unsafe to terminate a thread, as Sanja already mentioned. The typical solution in such cases is to spawn a child process that only role is to host the DLL and call the method(s). You main process will communicate with the child process via some LPC mechanism to pass in the arguments for the DLL method invocation and get back the result. On timeout is perfectly safe to kill the child process, the kernel will reclaim all resources and there will be no in-memory or system object leaks (there could be persisted on-disk leaks, like files left over, though). It is significantly more complicated that just simply calling the DLL (you'll need to come up with the inter-process communication solution) but is the only reliable way.

answered Aug 15 '11 at 18:13

Remus Rusanu

288,378
40
442
569

thanks for the reply. Could you possibly explain a bit more? By LPC do you mean local procedure call? And when you talk about a child process do you mean a completely separate exe rather than a worker thread? – House Sparrow Aug 16 '11 at 07:19
Yes, by LPC I mean any local interprocess communication (could be implemented using COM, shared memory, net pipes, WCF etc). A separate process is usually another .exe, but technically it could be the same .exe launched again, with different parameters. Prefferably a separate .exe – Remus Rusanu Aug 16 '11 at 15:46
Thank you, that was most helpful. – House Sparrow Aug 23 '11 at 08:31

Worker thread termination in MFC

2 Answers2