1

I have a Spring MVC sample application it uses UserDaoImpl class to save a User type object to database. Following is the UserDaoImpl code.

public class UserDaoImpl implements UserDao<User> {

private EntityManagerFactory emf;

@PersistenceContext
private EntityManager em;

@Transactional
public void saveUser(User user){
    em.persist(user);
}

}

and my UserDao interface looks like this.

public interface UserDao<User> {
public void saveUser(User user);

}

Weird thing is happening when when my UserDaoImpl class implements the UserDao interface. When trying to persist it gives the following error.

java.lang.ClassCastException: $Proxy71 cannot be cast to org.samith.UserDaoImpl

When I remove the "implements UserDao" part from the UserDaoImpl class user is persisted to database as expected.

Also I tried UserDao interface without User parameter(that is non generic version). Still above error occurs.

This may be a trivial question to answer but I am scratching my head finding a solution for about few hours.

What wrong am I doing ??

David Grant
  • 13,929
  • 3
  • 57
  • 63
nash
  • 705
  • 4
  • 14
  • 21

2 Answers2

3

You're not providing the problem code, (or the full stack trace) but the rundown is this:

When you annotate a class as @Transactional, and Spring creates an instance for you, what you get is not that class, but a Java Dynamic Proxy that implements that classes' interfaces. http://download.oracle.com/javase/1.3/docs/guide/reflection/proxy.html

Because of this, you cannot cast that object to the original type (it's not that type anymore!) and must use it's interface(s) instead.

If there aren't interfaces to implement, it will give you a CGLib proxy of the class, which is basically just a runtime modified version of your class, and so is assignable to the class itself.

Search for where you're injecting, or casting to type UserDaoImpl, and change the reference to UserDao instead, and it will work properly.

I've read the performance difference between CGLib proxies and Dynamic Java Proxies is quite minimal, so you can also add the following to your spring config to force it to use CGLib proxies instead of Java Dynamic Proxies:

<aop:config proxy-target-class="true">

In general however, I'd recommend you not use CGLib Proxies, but instead access your class from its interface. Loose coupling will allow you to do runtime substitution, and limits your ability to accidentally introduce brittle class dependencies.

There are some problems that using Java Dynamic Proxies will introduce however, and what you're doing is close enough to what I was doing that you should be aware of this:

How to use Dynamic Proxies with JSF when the method signature contains Object ... args

Community
  • 1
  • 1
SplinterReality
  • 3,400
  • 1
  • 23
  • 45
  • Yep. It worked. Thanks for the reply Charles. Adding is of course not necessary, The problem was I was using getBean method of ClassPathXmlApplicationContext and trying to cast it to UserDaoImpl class instead of UserDao interface type, thanks again. – nash Aug 15 '11 at 07:30
  • @Charles nice answer, but I'd like to add that `@Transactional` shouldn't be set on the dao level, anyway (It belongs on the service level), except perhaps for `@Transactional(REQUIRED)` – Sean Patrick Floyd Aug 15 '11 at 08:53
  • @Sean I've always annotated my DAOs as required so that they create their own transactions if one doesn't already exist. That allows re-use of the DAO at multiple levels of the application, which can be useful in certain circumstances. REQUIRES_NEW would be a mistake, but I don't see any problem with using `@Transactional` (defaults to REQUIRED), REQUIRED or SUPPORTS. – SplinterReality Aug 16 '11 at 02:13
  • @Charles I agree, to an extent. It's not clean, but it's a lifeline that will save you from bad coding :-) – Sean Patrick Floyd Aug 16 '11 at 07:24
0
<tx:annotation-driven transaction-manager="transactionManager" proxy-target-class="true"/>

worked for me too. the point was proxy-target-class="true" thanks to owner of the accepted answer. But then cglib dependency will be needed.

merveotesi
  • 2,145
  • 15
  • 53
  • 84