StatefulRetryOperationsInterceptor not working when included with TransactionInterceptor in interceptor chain

Question

I have the below configuration in application context xml file

    <bean id="methodMapWithDefaultTxAttributeSource" class="org.springframework.transaction.interceptor.MatchAlwaysTransactionAttributeSource">
        <property name="transactionAttribute" value="PROPAGATION_REQUIRES_NEW,timeout_60"/>
    </bean>
    
    <bean id="methodMapTxInterceptor"
          class="org.springframework.transaction.interceptor.TransactionInterceptor">
        <property name="transactionManager" ref="txManager"/>
        <property name="transactionAttributeSource" ref="methodMapWithDefaultTxAttributeSource"/>
    </bean>

    <bean class="org.springframework.aop.framework.autoproxy.BeanNameAutoProxyCreator">
        <property name="interceptorNames">
            <list>
                <idref bean="retryAdvice"/>
                <idref bean="methodMapTxInterceptor"/>
            </list>
        </property>
        <property name="beanNames">
            <value>service</value>
        </property>
    </bean>
    
    <bean id="txProxyTemplate"
        class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean"
        abstract="true">
        <property name="transactionManager" ref="txManager" />
        <property name="transactionAttributes">
            <props>
                <prop key="*">PROPAGATION_REQUIRES_NEW,timeout_60</prop>
            </props>
        </property>
    </bean>
    
    <bean id="manager1" class="package2.Manager1">
        <constructor-arg ref="dataSource"/>
    </bean>
    
    <bean id="manager2" class="package2.Manager2">
        <constructor-arg ref="dataSource"/>
    </bean>
    
    <bean id="manager1TxProxy" parent="txProxyTemplate">
        <property name="proxyTargetClass" value="true" />
        <property name="target" ref="manager1" />
    </bean>
    
    <bean id="manager2TxProxy" parent="txProxyTemplate">
        <property name="proxyTargetClass" value="true" />
        <property name="target" ref="manager2"/>
    </bean>

    <bean id="retryPolicy" class="org.springframework.retry.policy.SimpleRetryPolicy">
        <constructor-arg name="maxAttempts" value="3"/>
    </bean>
    
    <bean id="retryTemplate" class="org.springframework.retry.support.RetryTemplate">
        <property name="retryPolicy" ref="retryPolicy"/>
    </bean>
    
    <bean id="rollbackClassifier" class="org.springframework.classify.BinaryExceptionClassifier">
        <constructor-arg name="typeMap">
            <util:map map-class="java.util.HashMap" key-type="java.lang.Class" value-type="java.lang.Boolean">
                <entry key="java.lang.NullPointerException" value="false"/>
            </util:map>
        </constructor-arg>
        <constructor-arg name="defaultValue" value="true"/>
        <constructor-arg name="traverseCauses" value="true"/>
    </bean>
    
    <bean id="retryAdvice" class="org.springframework.retry.interceptor.StatefulRetryOperationsInterceptor">
        <property name="retryOperations" ref="retryTemplate"/>
        <property name="rollbackClassifier" ref="rollbackClassifier"/>
        <property name="label" value="label"/>
    </bean>
   
    <bean id="service" class="package2.Service">
        <property name="manager1" ref="manager1"/>
        <property name="manager2" ref="manager2TxProxy"/>
    </bean>

As you can see i have wrapped a interceptor chain around Service class method. The goal is add retry and transaction facility to all Service class method. I have modified the Service class below method to throw exception whenever it is called

public void executeWithException() {
        manager1.execute();
        throw new NullPointerException();
        //manager2.execute();
    }

Now in the first try, the interceptor chain has StatefulRetryOperationsInterceptor and TransactionInterceptor and before calling the Service class method transaction is created. The Service class method throws exception and it will retry.

Now in the second retry, the interceptor chain will have only StatefulRetryOperationsInterceptor and not TransactionInterceptor. I feel this is wrong. Even for second retry a new transaction has to be created. The javadoc says that. But is not happening here. The TransactionInterceptor is skipped.

Am i missing some configuration here.

Please help me out. Screenshot of call stacktrace on first retry Screenshot of call stacktrace on second retry

Hi Gary, I tried your example. I created my own transaction manager as shown below

public class MyTransactionManager extends AbstractPlatformTransactionManager {
    private int i = 0;
    
    @Override
    protected Object doGetTransaction() throws TransactionException {
        return new Object();
    }

    @Override
    protected void doBegin(Object transaction, TransactionDefinition definition) throws TransactionException {
        System.out.println("Transaction" + i);
        i = i + 1;
    }

    @Override
    protected void doCommit(DefaultTransactionStatus status) throws TransactionException {
        
    }

    @Override
    protected void doRollback(DefaultTransactionStatus status) throws TransactionException {
        
    }
}

Used it in the xml file

<bean id="txManager" class="package2.MyTransactionManager"/>

Below is the console output

Transaction0
Manager1 Execute
Manager1 Execute
Manager1 Execute
Exception in thread "main" 

As you see transaction doBegin method is called once printing "Transaction0". This shows new transactions are not created for every retry.

Below is the main method

public class Example2 {
    public static void main(String[] args) {
        ApplicationContext context = new ClassPathXmlApplicationContext("example2.xml");
        Service service1 = (Service)context.getBean("service");

        service1.executeWithException();
    }
}

When I debugged the code, TransactionInterceptor is in the chain but it is skipped on subsequent retry.

Answer 1

It makes no sense that the interceptor would change between calls; you must be mistaken.

It works fine for me with similar configuration as yours:

@SpringBootApplication
@ImportResource("so70609332-context.xml")
public class So70609332Application {

    public static void main(String[] args) {
        SpringApplication.run(So70609332Application.class, args);
    }

    @Bean
    TransactionInterceptor txInterceptor(TransactionManager tm) {
        return new TransactionInterceptor(tm, new MatchAlwaysTransactionAttributeSource());
    }

    @Bean
    ApplicationRunner runner(Service service, MyTransactionManager tm) {
        return args -> {
            while (true) {
                try {
                    callIt(service);
                }
                catch (IllegalStateException e) {
                }
                catch (Exception e) {
                    System.out.println(tm.begins);
                    break;
                }
            }

        };
    }

    private void callIt(Service nt) {
        try {
            nt.foo();
        }
        catch (IllegalStateException e) {
            throw e;
        }
    }

}

class Service {

    void foo() {
        System.out.println("called: " + TransactionSynchronizationManager.isActualTransactionActive());
        throw new IllegalStateException();
    }

}

@Component
class MyTransactionManager extends AbstractPlatformTransactionManager {

    int begins;

    @Override
    protected Object doGetTransaction() throws TransactionException {
        return new Object();
    }

    @Override
    protected void doBegin(Object transaction, TransactionDefinition definition) throws TransactionException {
        this.begins++;
    }

    @Override
    protected void doCommit(DefaultTransactionStatus status) throws TransactionException {
    }

    @Override
    protected void doRollback(DefaultTransactionStatus status) throws TransactionException {
    }

}

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd">

    <bean
        class="org.springframework.aop.framework.autoproxy.BeanNameAutoProxyCreator">
        <property name="interceptorNames">
            <list>
                <idref bean="retryAdvice" />
                <idref bean="txInterceptor" />
            </list>
        </property>
        <property name="beanNames">
            <value>service</value>
        </property>
    </bean>

    <bean id="retryTemplate"
        class="org.springframework.retry.support.RetryTemplate">
    </bean>

    <bean id="retryAdvice"
        class="org.springframework.retry.interceptor.StatefulRetryOperationsInterceptor">
        <property name="retryOperations" ref="retryTemplate" />
        <property name="label" value="label" />
    </bean>

    <bean id="service" class="com.example.demo.Service" />

</beans>

called: true
called: true
called: true
3