I'm making a Discord Py bot that triggers a while loop and starts censoring bad words

Question

# Imports
import discord
import random
import os
from discord.ext import commands
from keep_alive import keep_alive

# Credentials
TOKEN = os.environ['Token']

# Create bot
client = commands.Bot(command_prefix='Aimby')

badword = ["word1","word2","word3"]
censorprotocol = False

# Startup Information
@client.event
async def on_ready():
  print('Starting bot: {}'.format(client.user.name))
  print('Status: Online')

@client.event
async def on_message(message):
#Aimby censoring
  censorprotocol = False   
  if message.content.startswith('Aimby initiate censor protocol'):
    if censorprotocol == False:
      await message.channel.send("Censoring bad words.")
      censorprotocol = True
    else:
      await message.channel.send("Already censoring bad words.")

  if message.content.startswith('Aimby complete censor protocol'):
    if censorprotocol == True:
      await message.channel.send("Stopped censoring bad words.")
      censorprotocol = False
    else:
      await message.channel.send("Currently not censoring bad words.")
    
  while censorprotocol == True:
    if censorprotocol == True and any(word in message.content.lower() for word in badword):
      await message.delete()
      await message.channel.send("Language!")
    else:
      return

keep_alive()
client.run(TOKEN)

So I want to create a boolean variable that would normally be false. When I say "Aimby initiate censor protocol" it should make the variable true, thus also triggering the while loop. But for some reason, the "censorprotocol" variable does not change states (true or false) and the bot doesn't read the text in the while loop (plus I don't think it works).

Answer 1

You don't need to have a while loop inside the on_message function, just the if condition and the if block code is enough, and better use @client.command() stuff instead of if/else statement for each command in on_message function

And as esqew said, You set censorprotocol to False every time on_message is invoked, which will disable your censoring protocol whenever anyone sends a message

Try this code

# Imports
import discord
import random
import os
from discord.ext import commands
from keep_alive import keep_alive

# Credentials
TOKEN = os.environ['Token']

# Create bot
client = commands.Bot(command_prefix='Aimby', strip_after_prefix=True)

badword = ["word1","word2","word3"]
censorprotocol = False

# Startup Information
@client.event
async def on_ready():
  print('Starting bot: {}'.format(client.user.name))
  print('Status: Online')

@client.listen('on_message')
async def on_message_function(message):
  global censorprotocol
    
  if censorprotocol and any(word in message.content.lower() for word in badword):
    await message.channel.send("Language!")
    await message.delete()
  else:
    return

@client.command(name='icp')
async def initiate_censor_protocol(ctx):
  global censorprotocol
  if not censorprotocol:
    await ctx.send("Censoring bad words.")
    censorprotocol = True
  else:
    await ctx.send("Already censoring bad words.")

@client.command(name='ccp')
async def complete_censor_protocol(ctx):
  global censorprotocol
  if censorprotocol:
    await ctx.send("Stopped censoring bad words.")
    censorprotocol = False
  else:
    await ctx.send("Currently not censoring bad words.")

keep_alive()
client.run(TOKEN)

By this code, you would use the commands like Aimby icp for initiating the protocol, and Aimby ccp for stopping the protocol (there can be no spaces in the command names, so I shortened it like that)

Or you can change whatever u want in the name parameter of the @client.command() decorator

Tell me if its not working...