username with `james i. adams` not accepted with django routers

Question

I have registered routers for user model, which has viewset that has lookup_url as username. The username james adams is accepted by the router, but getting below error for james i. adams

django.urls.exceptions.NoReverseMatch: Reverse for 'user-detail' with keyword arguments '{'username': 'james i. adam', 'version': 'v1'}' not found. 4 pattern(s) tried: ['(?P<version>(v4))/users/(?P<username>[^/.]+)/?\\.(?P<format>[a-z0-9]+)/?$', '(?P<version>(v4))/users/(?P<username>[^/.]+)/?$', '(?P<version>(v1))/users/(?P<username>[^/.]+)/?\\.(?P<format>[a-z0-9]+)/?$', '(?P<version>(v1))/users/(?P<username>[^/.]+)/?$']

Can someone guide me, how can I allow such username for url patterns with routers registered?

Thanks in Advance

I see you do have an answer, but more standard practice might be to generate a unique slug for the record and use that in the URL instead of the actual username. If you look at the SO URL for this question, that's exactly what they are doing there ... — michjnich, Dec 15 '21 at 09:04

score 2 · Accepted Answer · answered Dec 15 '21 at 08:15

2

As you see, the default regex for URL values excludes .:

/users/(?P<username>[^/.]+)/
                       ^

You will have to change that regex; if you're using viewsets, that's as easy as:

class UserViewSet(ModelViewSet):
    lookup_value_regex = '[^/]+'

answered Dec 15 '21 at 08:15

deceze

510,633
85
743
889

Thanks alot ! It worked :) Just want to know if you know any specific reason why by default they don't allow `.` character? Is it coz it might be security vulnerable or lead to some invalid url? – sandeshdaundkar Dec 15 '21 at 08:36
1

Probably because it accepts `.json`, `.xml` etc. in the URL to switch to different return formats. – deceze Dec 15 '21 at 08:37
okay thank you :) – sandeshdaundkar Dec 15 '21 at 08:40

username with `james i. adams` not accepted with django routers

1 Answers1