Value stored to `item` during its initialization is never read in range base loop

Asked Dec 13 '21 at 16:20

Active Dec 13 '21 at 16:23

Viewed 202 times

I am trying to fix analyzer errors, but I am stuck at this error, have no idea why I am getting this error here is my code.

struct Config{
  std::shared_ptr<std::set<int>> data;
  std::shared_ptr<std::set<int>> getData(){
     return data;
  }
}

void Engine::Notify()
{
    if(allowed)
    {
        for (auto item: *config.getData())
        {
            process->dispatch(item);
        }
    }

}

Error: Value stored to 'item' during its initialization is never read

edited Dec 13 '21 at 16:23

asked Dec 13 '21 at 16:20

foragerDev

1,307
1
9
22

2

On an unrelated note, pointers to standard containers are almost never needed. – Some programmer dude Dec 13 '21 at 16:23
That sounds more like a warning. What does `process->dispatch()` do? – scohe001 Dec 13 '21 at 16:23
yeah, but its already there in the project. and I have to fix linter errors. – foragerDev Dec 13 '21 at 16:24
@scohe001 its sents notification. – foragerDev Dec 13 '21 at 16:24
but `dispatch` takes by value, can it be because of that? – foragerDev Dec 13 '21 at 16:25
Probably. If `dispatch` takes by value, then the copy you made in the for loop is unneeded and is a performance loss. – NathanOliver Dec 13 '21 at 16:27
1

Consider `const auto & item`. – Drew Dormann Dec 13 '21 at 16:28
looping by reference its worked fine. – foragerDev Dec 13 '21 at 16:34
Please post code for `dispatch`. – Hajo Kirchhoff Dec 13 '21 at 18:36
Assuming `dispatch(shared_ptr<...> &value)` it is possible that `dispatch` modifies but does not read `item`? – Hajo Kirchhoff Dec 13 '21 at 18:37

Value stored to `item` during its initialization is never read in range base loop

0 Answers0