How to break multiple if statements?

Question

I have a permission class for my viewset. But it has multiple if statements and the if statements can be added others as well if some action added inside viewset.

So how can I optimize my code here for better performance ?

 def has_permission(self, request, view):
     user = request.user
     if view.action in ["update", "partial_update"]:
         return user.is_manager
     if view.action == "create":
         return user.is_creator
     if view.action in ["list", "retrieve"]:
         return user.is_viewer
     if view.action == "destroy":
         return user.is_admin
     return False

Here different type of view actions would be performed by different user types.

A single comparison that `view.action` is in all of the valid actions would do what you want? — Iain Shelvington, Nov 29 '21 at 04:44
@IainShelvington different `view.action` are performed by different user types based on role so — D_P, Nov 29 '21 at 05:00

score 1 · Answer 1 · answered Nov 29 '21 at 05:09

Your method is actually fine, but if you are looking for a slightly more concise way, try this:

def has_permission(self, request, view):
    user = request.user
    actions = {"update": user.is_manager,
               "partial_update": user.is_manager,
               "create": user.is_creator,
               "list": user.is_viewer,
               "retrieve": user.is_viewer,
               "destroy": user.is_admin}
    return actions.get(view.action, False)

score -1 · Answer 2 · answered Nov 29 '21 at 04:56

-1

If your code is working well and you just want to optimize code than may be this could help you:

def has_permission(self, request, view):
        if view.action in ["update", "partial_update","list", "retrieve","destroy","create"]:
            return some_user
        return False

answered Nov 29 '21 at 04:56

sunil ghimire

505
4
14

`some_user` would be different based on action types – D_P Nov 29 '21 at 05:03

How to break multiple if statements?

2 Answers2