NSInteger and int giving exceptions

Question

I'm trying to get data from a database using FMDB but having tried with futility for a while, I can't figure out why this is throwing an EXC_BAD_ACCESS exception. The parameter is passed in from an NSInteger, but I can neither log it nor use it in a SELECT statement. The code I have is:

-(SQLiteResult*) getClient:(bool)forceRefresh id:(NSString*)id forYear:(NSInteger)year {
    SQLiteResult *res;
    if(!forceRefresh){
        NSMutableArray *hereditaments = [[NSMutableArray alloc] init];
        NSLog([NSString stringWithFormat:@"SELECT * FROM Clients WHERE ID = %@ AND Year = %@", id, [NSString stringWithFormat:@"%@", year]]); // exception
        NSLog([NSString stringWithFormat:@"SELECT * FROM Clients WHERE ID = %@ AND Year = %@", id, year]]); // also exception
        FMResultSet *rs = [db executeQuery:[NSString stringWithFormat: @"SELECT * FROM Clients WHERE ID = ? AND Year = %@", year], id]; // also exception
        FMResultSet *rs = [db executeQuery:[NSString stringWithFormat: @"SELECT * FROM Clients WHERE ID = ? AND Year = ?", id, year]]; // also exception

I'm on the verge of just passing it in as a string instead. Is there a safe way I can just use the year in the SQL statement?

score 3 · Answer 1 · answered Aug 10 '11 at 12:19

3

NSInteger is not an object type. Its just a typedef of type int. So, you can not use %@ as the format specifier. You should use %d.

answered Aug 10 '11 at 12:19

EmptyStack

51,274
23
147
178

score 0 · Accepted Answer · answered Aug 10 '11 at 12:12

0

As your year variable is of NSInteger type you should use %d format and not %@ in your NSString creation

answered Aug 10 '11 at 12:12

gsempe

5,371
2
25
29

Formatting it as %d instead of passing it to the query as a parameter worked. Thanks. – Echilon Aug 10 '11 at 12:32

NSInteger and int giving exceptions

2 Answers2