-3

I have different cases up, down , left and right. Sometimes the choice is not valid and the user is required to input another choice. For example, I want to shift the elements up, but all of them are placed up already, the program shouldn't generate a new (2) value, instead ask a user to input a new choice other than up. Here is my code, it works perfectly for the move but not when having invalid choices. Anyone can help??

isValid = True
    while True:
        if isValid:
            one = generate_piece(game_board, DEV_MODE)
            game_board[one['row']][one['column']] = one['value']
            print_board(game_board)
            
        if True:
            choice = input() 
            if choice == 'w':
                isValid = False
                for col in range(4):
                    tracker1 = 0
                    tracker2 = 0
                    for row in range(4):
                        if game_board[row][col] == 0:
                            continue
                        if tracker2 == game_board[row][col]:
                            game_board[tracker1][col] = 2 * tracker2
                            tracker1 = tracker1 + 1
                            tracker2 = 0
                            
                        elif tracker2 == 0:
                            tracker2 = game_board[row][col]
                        else:
                            game_board[tracker1][col] = tracker2
                            tracker1 = tracker1 + 1
                            tracker2 = game_board[row][col]
                    if tracker2 != 0:
                        game_board[tracker1][col] = tracker2
                        tracker1 = tracker1 + 1
                    for row in range(tracker1, 4):
                        game_board[row][col] = 0
                        isValid = True
                        
            elif choice == 's':
                isValid = False
                for col in range(4):
                    tracker1 = 3
                    tracker2 = 0
                    for row in range(3, -1, -1):
                        if game_board[row][col] == 0:
                            continue
                        if tracker2 == game_board[row][col]:
                            game_board[tracker1][col] = 2 * tracker2
                            tracker1 = tracker1 - 1
                            tracker2 = 0
                           
                        elif tracker2 == 0:
                            tracker2 = game_board[row][col]
                            
                        else:
                            game_board[tracker1][col] = tracker2
                            tracker1 = tracker1 - 1
                            tracker2 = game_board[row][col]
                    if tracker2 != 0:
                        game_board[tracker1][col] = tracker2
                        tracker1 = tracker1 - 1
                    for row in range(tracker1 + 1):
                        game_board[row][col] = 0
                        isValid = True
                            
            elif choice == 'd':
                isValid = False
                for row in range(4):
                    tracker1 = 3
                    tracker2 = 0
                    for col in range(3, -1, -1):
                        if game_board[row][col] == 0:
                            continue
                        if tracker2 == game_board[row][col]:
                            game_board[row][tracker1] = 2*tracker2
                            tracker1 = tracker1 - 1
                            tracker2 = 0
                        elif tracker2 == 0:
                            tracker2 = game_board[row][col]
                            
                        else:
                            game_board[row][tracker1] = tracker2
                            tracker1 = tracker1 - 1
                            tracker2 = game_board[row][col]
                    if tracker2 != 0:
                        game_board[row][tracker1] = tracker2
                        tracker1 = tracker1 - 1
                    for col in range(tracker1 + 1):
                        game_board[row][col] = 0
                        isValid = True
                    
            elif choice == 'a':
                isValid = False
                for row in range(4):
                    tracker1 = 0
                    tracker2 = 0
                    for col in range(4):
                        if game_board[row][col] == 0:
                            continue
                        if tracker2 == game_board[row][col]:
                            game_board[row][tracker1] = 2 * tracker2
                            tracker1 = tracker1 + 1
                            tracker2 = 0
                    
                        elif tracker2 == 0:
                            tracker2 = game_board[row][col]
                           
                        else:
                            game_board[row][tracker1] = tracker2
                            tracker1 = tracker1 + 1
                            tracker2 = game_board[row][col]
                    if tracker2 != 0:
                        game_board[row][tracker1] = tracker2
                        tracker1 = tracker1 + 1
                    for col in range(tracker1, 4):
                        game_board[row][col] = 0
                        isValid = True
            elif choice == 'q':
                print('Goodbye')
                break
            else:
                print('Invalid input.')
Random Davis
  • 6,662
  • 4
  • 14
  • 24
user17421902
  • 1
  • 2
    This is a lot of code to look through. I recommend stepping through it in a debugger (like [this](https://www.jetbrains.com/help/pycharm/debugging-your-first-python-application.html) free one), line-by-line, and seeing where the execution diverges from your expectations. – Random Davis Nov 15 '21 at 20:54

1 Answers1

0

You would have to check whether any assignment to a board cell changes it from its previous value. If so, then isValid should be set to True.

I would also suggest that you reduce your code as currently it has very similar code for the four different directions. Make the direction a variable that you use in the further logic.

For instance:

isValid = True
while True:
    if isValid:
        one = generate_piece(game_board, DEV_MODE)
        game_board[one['row']][one['column']] = one['value']
        print_board(game_board)
        
    if True:
        choice = input() 
        if choice in "wasd":
            dx, dy = {
                "a": (-1, 0),
                "w": (0, -1),
                "s": (0, 1),
                "d": (1, 0) 
            }[choice]
            isValid = False
            for line in range(4):
                sourcerow = targetrow = [0, line, 3][dy + 1]
                sourcecol = targetcol = [0, line, 3][dx + 1]
                for steps in range(3):
                    sourcerow -= dy
                    sourcecol -= dx
                    source = game_board[sourcerow][sourcecol]
                    if source:
                        target = game_board[targetrow][targetcol]
                        if source == target:
                            game_board[sourcerow][sourcecol] = 0
                            game_board[targetrow][targetcol] *= 2
                            targetrow -= dy
                            targetcol -= dx
                            isValid = True
                        else:
                            if target:
                                targetrow -= dy
                                targetcol -= dx
                            if (targetrow, targetcol) != (sourcerow, sourcecol):
                                game_board[sourcerow][sourcecol] = 0
                                game_board[targetrow][targetcol] = source
                                isValid = True
        elif choice == 'q':
            print('Goodbye')
            break
        else:
            print('Invalid input.')
trincot
  • 317,000
  • 35
  • 244
  • 286